Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace editor - 'Save' button is not grayed out while offline after changing the name #12008

Closed
kbecciv opened this issue Oct 19, 2022 · 3 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Oct 19, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open NewDot Desktop App
  2. Turn the network off
  3. Try to rename the WS and click on the save button

Expected Result:

The Save button and the text input is now grayed out

Actual Result:

'Save' button is not grayed out

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.18.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/93399543/196805417-9c135dee-57be-4ffc-b594-4254f9412c5c.mp4
Screenshot 2022-10-19 at 20 42 11

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2022

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@rushatgabhane
Copy link
Member

@johnmlee101 this will be fixed by #11615

And this issue can be closed

@johnmlee101
Copy link
Contributor

Nice catch. closing then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants