Deploy Checklist: New Expensify 2022-10-28

[OSBotify]

Release Version: 1.2.21-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add login list format update (Array -> Object) #10959
• Set optimistic default notification preference #11653
• Workspaces list #11784
• [NoQA] Update Standard.md #12030
• Fix placeholder overlaps date picker label on Firefox #12078
• Fix saving draft values for Checkboxes #12080
• fix: 11584 web jump to unread message #12124
• fix image styles in article pages #12136
• add defaultProps of isComposerFullSize in Composer #12149
• Revert "Upgrade react-native-svg to 13.4.0" #12176
• Use Onyx set if creating new report #12192
• [NoQA] Add space for QA #12193
• [No QA] Improve EmojiTests #12196
• Bump react native SVG lib to unblcok Fabric #12202
• Bump react-native-onyx to 1.0.26 #12211
• Add loading spinner to IOUConfirmationList #12216

Deploy Blockers:

• Chat -PDF file is not visible in the chat conversation, but it can be downloaded. #12275
• [HOLD] [$250] IOS - LHN - The Global create menu is not automatically displayed after you log in for the first time #12281

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.21-4 🚀

[mountiny]

Checking #12193 off since it is also noQA

Same for #12030

[mvtglobally]

Interim summary

PR #11784 failing with #12265. repro in PROD checking off
PR #12124 is failing due to #12249. It is PR fail, so we did not add DeployBlocker label. Pls double check
PR #12136 looks PROD QA. Are we ok to check off?

[mvtglobally]

Regression is completed

Deploy Blocker
#12275

Open PRs
PR #12124 is failing due to #12249. It is PR fail, so we did not add DeployBlocker label. Pls double check
PR #12136 looks PROD QA. Are we ok to check off?

[Julesssss]

Hi @mvtglobally. I agree with #12249 being a bug, but not a deploy blocker. I've checked off #12124 as the PR test steps are passing (at least on the first use).

[Julesssss]

#12136 was checked off as it's untestable outside of prod.

[Julesssss]

#12275 is now reproducable on prod, so this is not a mobile regression. Continueing to move forward once the last regression is resolved

[Julesssss]

I checked off the final blocker, #12281 as it was not reproducible for me on web or iOS

[Julesssss]

Switch Report is looking better in the App performance timing dashboard. Homepage initial render is worse, but we are aligned on the fact that this is due to a change in the timing logic and doesn't accurately represent a regression.

[Julesssss]

The only new crashlytics issues were from the SVG library crash that was resolved in the last deploy. I cleared up the console while I was there.

[Julesssss]

Okay, all is good except this bug which was raised against an old issue. I have asked for help with testing as I'm unable to proceed past the 2nd step.

[Julesssss]

Hi, @Expensify/applauseleads. I saw that this crash was raised, which could well be a deploy blocker. I closed the original issue because it has a different underlying issue, but it would be great if you could open a new issue if it is still occurring and please test on both staging and prod.

Thanks!

[Julesssss]

@chiragsalian kindly tested the issue above and wasn't able to reproduce it. @Expensify/applauseleads if you are still able to reliably reproduce this, please open a new issue and I'll investigate further:

[Julesssss]