Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Bank Account - App is crashed when adding a Verified Bank Account #12172

Closed
kbecciv opened this issue Oct 27, 2022 · 14 comments
Closed
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 27, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Enable staging Web secure server in Account Preferences if disabled
  4. Navigate to the add bank account modal (Workspace settings > Add bank account)
  5. Verify the Add bank account modal is displayed with 2 options to add bank accounts (Log in and Manual)
  6. Select the Connect with plaid method to add a bank account
  7. On the bank account list select "Fidelity"
  8. Enter the credentials "user_good / pass_good"
  9. Select "Plaid Saving" account
  10. Click Save and Continue
  11. In the company information verify all fields are working as expected
  12. Fill out the fields with the required test credentials
  13. Verify you're able to continue to the personal information step.
  14. In the Personal information verify all fields are working as expected
  15. Fill out the fields with the required test credentials
  16. Verify you're able to continue.
  17. In the beneficial owners step toggle the last 2 checkboxes (terms and conditions and true information)
  18. Confirm you're able to continue and reach the validate step.
  19. Verify the bank account was added to the workspace

Expected Result:

App is not crashed when adding Verified Bank Account

Actual Result:

App is crashed when adding a Verified Bank Account

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web

Version Number: 1.2.20.0

Reproducible in staging?: Yes

Reproducible in production?: N/A

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1527.mp4
Screen_Recording_20221026-210902_Chrome.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Oct 27, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 27, 2022

Everybody was OOO, so I assigned 10 random eligible people.

@pecanoro
Copy link
Contributor

I tried to reproduce it but it is not crashing for me, it works just fine, can someone else test it as well?

@NikkiWines
Copy link
Contributor

NikkiWines commented Oct 27, 2022

Also unable to reproduce on staging

@Julesssss
Copy link
Contributor

It's possibly linked to these two crashes, reported at the same time. We're about to CP a fix and then will retest this one to see if it's still occurring.

@Julesssss
Copy link
Contributor

I'm going to ask Applause to retest this one, once the Android fix is CP'd to the deploy checklist

@Julesssss
Copy link
Contributor

Asked Applause to retest here

@mvtglobally
Copy link

@Julesssss Issue seem fixed

Recording.1538.mp4

@Julesssss
Copy link
Contributor

Excellent, thank you!

@kbecciv
Copy link
Author

kbecciv commented Oct 31, 2022

Issue have been reproduced with build 1.2.21.4 with two testers.

Recording.1553.mp4

@kbecciv kbecciv reopened this Oct 31, 2022
@Julesssss
Copy link
Contributor

Hi, thanks for the report but the issue is different. Could you please open a new issue?

The stack trace is:

Account not found in EnableStep in u.value (EnableStep.js:77:19)

@Julesssss
Copy link
Contributor

Hey @kbecciv, is this only reproducible on the latest version?

@kbecciv
Copy link
Author

kbecciv commented Oct 31, 2022

Hello @Julesssss The issue occurred in build 1.2.21.4. Let me create a new GH issue for it.

@kbecciv
Copy link
Author

kbecciv commented Oct 31, 2022

Here is the link for new GH issue #12308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests