[HOLD for payment 2023-02-10] Update new chat empty state

[shawnborton]

Note: This issue is part of the greater Implement Our New Branding in NewDot project.

What is it:
Updating the default screen you see when you first start a chat with someone. Let’s also use our green brick road pattern for the green plus button (highlight this button in green until text is typed), and let’s use a randomized message for “Say hello!”

Does it require a mini design doc:
Yes, this requires code changes

Design finished: No, still need to create designs for default rooms, group chats, etc.

cc @GabiHExpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019d6a1829f0afc04e
• Upwork Job ID: 1605699152274489344
• Last Price Increase: 2022-12-21

[melvin-bot]

Auto-assign attempt failed, all eligible assignees are OOO.

[dangrous]

Lemme know what you need in order to help with the design and/or design doc! First time getting involved this early in a project so not sure what's most useful at this point.

[JmillsExpensify]

If you need any help with the high-level design in the mini-doc, I think this one could probably use a more fleshed out non-detailed part – especially for our approach to GBR as well as the randomized welcome messages.

[shawnborton]

We're hoping to have another engineer join in on the fun and help lead this one, I'll keep soliciting volunteers in the room this week.

[shawnborton]

Posted some Slack discussion here

[shawnborton]

Okay so based on the Slack discussion, we decided against:

• any kind of special green brick road plus button treatment
• random welcome messages

So that being said this one becomes way more straight forward and I don't think it needs a design doc. Curious if you agree @JmillsExpensify

[JmillsExpensify]

Agree 100%.

[dangrous]

Cool! I can start playing around with this this week, if no design doc needed. Will likely have some questions as I go. First one - are we removing the timezone call out that's in the left hand image?

[JmillsExpensify]

are we removing the timezone call out that's in the left hand image?

No, that's just a detail not included in the mock. Let's keep that functionality as is.

[shawnborton]

Yup agree, that was just an oversight on my part regarding the timezone.

[dangrous]

@shawnborton I am OOO all next week - is it okay to pick this up when I'm back on 11/28? If not I can see if I can find a willing sub in the meantime (not sure what our goal timeline here is)

[shawnborton]

I think we want to move as quickly as we can, so it can't hurt to see if anyone can take this over from you. Maybe by sending a quick message in open source letting people know it's up for grabs?

[melvin-bot]

Triggered auto assignment to @CherylWalsh (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[dangrous]

Hey @CherylWalsh ! Can we get confirmed copy for the Say hello! line, as well as the You can also use the + button below to send or request money. Try it, it's super easy! lines in the preview image above? #12256 (comment) This will show up when people first open a new chat, as well as scroll to the top of an existing chat. Thanks!

[parasharrajat]

I am fine with this exception and there can be two PRs but the general rule should be if a feature/issue does not depend on something, then that something can be a separate issue. Especially when different engineers are involved. That goes well with our process automation.

[mallenexpensify]

Thanks @mananjadhav and @parasharrajat. So...

1. In the future it's best to have separate GH issues to keep from there being multiple PRs linked to the same issue, right? I agree with this for multiple reasons - best practice, consistency, easier to follow/track/pay and also for automation inc. Upwork<>GH integration .
2. @mananjadhav 's been paid for his review, @parasharrajat you are also due $1000 7 days after Empty State Design #13647 is merged, correct? If so we'll leave this open.

[mananjadhav]

I am unassigning myself here now, as the main PR is tagged to @parasharrajat already.

[parasharrajat]

That works

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.64-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Empty State Design #13647

If no regressions arise, payment will be issued on 2023-02-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[dangrous]

I think we're good to pay and close this one out, right?

[shawnborton]

I would say so, yeah.

[mallenexpensify]

@parasharrajat , invited you to the job, can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~016aa125cd7c545ae8

From here

, @parasharrajat you are also due $1000 7 days after #13647 is merged, correct? If so we'll leave this open.

[parasharrajat]

Done.

[mallenexpensify]

Thanks @parasharrajat, can you please accept the job (again) and reply here once you have?
https://www.upwork.com/jobs/~016aa125cd7c545ae8

[shawnborton]

Not overdue. @parasharrajat see above please!

[parasharrajat]

I think I already applied to it.

[mallenexpensify]

@parasharrajat is paid $1000!