[$1000] [HOLD for payment 2022-12-15] Update New Dot Fonts

[Luke9389]

Tracking Issue: #12251
Design Doc Section: https://docs.google.com/document/d/197fXHLlHM_RJA4-3MITwdu0N5e0HX5Q74sA4W80YMD8/edit#bookmark=id.h4aw0750hafm

Update Fonts

Adding fonts to a React Native project requires a few steps for each platform, which are spelled out here.

Body Font
Our new body font will be Expensify Neue. We only need four weights: Regular, Regular Italic, Bold, and Bold Italic

Monospaced Font
Our new monospaced font (used for code blocks and inline code) will be Expensify Mono. We only need two weights: Regular and Bold.

Headline Font
Our new headline font is Expensify New Kansas. We only need two weights: Medium and Medium Italic. We currently do not have a separate headline font in the NewDot repo, so this will be a new addition.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fd6b44212c9f53b2
• Upwork Job ID: 1610444700701253632
• Last Price Increase: 2023-01-04

[Luke9389]

Hey @shawnborton, I fiddled around in Figma for a while to see if I could get the font files out of it, but alas, I could not.

Would you be willing to provide them here?

[shawnborton]

Can you let me know the exact font files we're currently using? I think I see that Android and iOS need .otf font files - is that right? For web/desktop/mWeb, I am guessing we need .woff files or something like that?

[shawnborton]

In the meantime, here are the files. You'll have to grab the exact ones you need from these folders, but I think it should be self-explanatory.

Expensify Mono: https://www.dropbox.com/sh/yp1s3pdnbwak5mc/AABLu3m4Fw0MZhctS5DS1w01a?dl=0
Expensify Neue: https://www.dropbox.com/sh/ek37aaosgsh84oh/AACBRBNB7Fk2Gngn8C6EhuGba?dl=0
Expensify New Kansas (note: only .otf files are there currently, waiting to get the other types): https://www.dropbox.com/sh/lkz4saovcora67e/AAAWmQPqIYHPBH8-pPp_hF0Za?dl=0

[Luke9389]

That first PR was to add the fonts as assets. Now I'll begin switching them out.

[Luke9389]

I'm realizing that we do indeed need the New Kansas .eot and .woff files.

[Luke9389]

Holding. Reason in above comments

[shawnborton]

Yup, still waiting to get the final formats for New Kansas once we sign the EULAs and pay final licensing. Will keep you posted!

[shawnborton]

If it's a pain, we could always follow up with New Kansas in a different PR?

[shawnborton]

@Luke9389 thinking more on this, I think we can probably follow up with a separate PR for New Kansas. This way we can get Expensify Neue out with the color and logo changes at least. Thoughts on that?

[Luke9389]

I think that'd be fine! The Help Site should probably hold til all 3 are done since its external. Do you agree?

[shawnborton]

I think it would be fine if the help site uses Expensify Neue for headlines for the time being.

[Luke9389]

OK one other thing is that the new "logo" of expensify help looks like this:

If you made an svg out of that, I could use it, or I could have that "Help" part be in Expensify Neue as well.

[Luke9389]

I'm just realizing that I think I'll need .eot files for Expensify Mono and Expensify Neue as well.

[shawnborton]

I think I already added the new help site logo to the Help Site issue.

Curious why you need .eot files? It's pretty standard to just use woff files for web/mWeb.

[Luke9389]

I think I already added the new help site logo to the Help Site issue.

Oh sick! Sorry bout missing that. I see those now.

Curious why you need .eot files? It's pretty standard to just use woff files for web/mWeb.

Honestly, I don't really know anything about font file types n' stuff.

But I do see that we have an .eot reference for every font in the app. Idk, if we need these exactly, but I'm assuming we do bc they're there. I dunno.

You know more about this than me so lmk what you think.

One thing is that this code isn't just for web and mWeb, it's compiling to iOS and Android.

[shawnborton]

I think Android and iOS end up using .otf font files, so we should be good there.

Then for web/mWeb, yeah - let's try to only use woff files and see what happens.

[Luke9389]

Ok I just did some reading and it looks like .eot is really only supported/used in Internet Explorer.

I know you're OOO, and we can just add them later. For now I'll continue w the PR.

[shawnborton]

Could we please try just implementing the woff files? I think it's pretty standard practice to only use these file types for serving up web/mWeb fonts.

[Luke9389]

Still working on this one.

[Luke9389]

This one should be getting merged very soon (hopefully today)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.36-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add New Fonts #12656

If no regressions arise, payment will be issued on 2022-12-15. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[Luke9389]

Looks like there was a problem with the fonts on android. @grgia is looking into it and may include the fix on her PR here.

[Luke9389]

Idk why this one says Awaiting Payment. Closing now.

[sobitneupane]

@Luke9389 @grgia I am C+ in the PR. Can you please help me with the payment.

[Luke9389]

Sorry about that @sobitneupane, I'll get a CM assigned right now.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fd6b44212c9f53b2

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Current assignees @Luke9389 and @grgia are eligible for the External assigner, not assigning anyone new.

[Luke9389]

Hey, @jliexpensify, would you be willing to pay @sobitneupane above? Looks like there was never a CM for this one.

[jliexpensify]

@sobitneupane - invited you. Once you accept, I can get the $1000 payment sorted :)

[sobitneupane]

@jliexpensify Thanks. Submitted proposal.

[jliexpensify]

Paid and job closed!

[Luke9389]

Thanks @jliexpensify!