-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new core brand ingredients #12251
Comments
Auto-assign attempt failed, all eligible assignees are OOO. |
We want this design doc to be reviewed ASAP because it's a fast change that dramatically improves our app. Also it's been lumped into WAQ (WhatsApp Quality) so the level of urgency is high (n7 to be specific). |
I have read and reviewed this Design Doc! |
I have read and reviewed this Design Doc! |
3 similar comments
I have read and reviewed this Design Doc! |
I have read and reviewed this Design Doc! |
I have read and reviewed this Design Doc! |
I have read and reviewed this design doc |
I have read and reviewed this Design Doc! |
1 similar comment
I have read and reviewed this Design Doc! |
I have read and reviewed this design doc |
I have read and reviewed this Design Doc! |
Whoops, I reviewed this 2 weeks ago and didn't comment. |
I have read and reviewed this Design Doc! |
1 similar comment
I have read and reviewed this Design Doc! |
Still in progress! Right now we're fixing the last few dark-mode/font bugs and TestRail QA for Applause |
Out of curiosity, why are we keeping this main issue open if the initial implementation is now complete? I think it's great that we already have a bunch of follow-on issues to track bugs, I just thought that everything from the initial push was already done. Is that right, and if so, how about closing this issue? |
I think because we're still waiting on text inputs to get merged |
Gotcha, thanks for pulling out that PR. Hopefully we can close the loop on that one when everyone returns next week, and at that point, close this individual issue out. |
I'm iterating on reviews for Text Inputs daily. Hoping to see it merged soon! |
I think we can close this one out since the text inputs have been merged. |
Note: This issue is part of the greater Implement Our New Branding in NewDot project.
Design Doc: https://docs.google.com/document/d/197fXHLlHM_RJA4-3MITwdu0N5e0HX5Q74sA4W80YMD8/edit#
What is it:
Updating our old colors, logos, icons, and fonts with new brand ingredients. Updating our old button styles to look like pill shapes, and updating our text input styles to use a single bottom-border style.
We've also decided to make the dark colors the new default colorway.
Does it require a mini design doc:
Yes
Design finished:
Yes
cc @GabiHExpensify
The text was updated successfully, but these errors were encountered: