Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new core brand ingredients #12251

Closed
shawnborton opened this issue Oct 28, 2022 · 22 comments
Closed

Implement new core brand ingredients #12251

shawnborton opened this issue Oct 28, 2022 · 22 comments
Assignees

Comments

@shawnborton
Copy link
Contributor

shawnborton commented Oct 28, 2022

Note: This issue is part of the greater Implement Our New Branding in NewDot project.

Design Doc: https://docs.google.com/document/d/197fXHLlHM_RJA4-3MITwdu0N5e0HX5Q74sA4W80YMD8/edit#

What is it:
Updating our old colors, logos, icons, and fonts with new brand ingredients. Updating our old button styles to look like pill shapes, and updating our text input styles to use a single bottom-border style.

We've also decided to make the dark colors the new default colorway.

image

Does it require a mini design doc:
Yes

Design finished:
Yes

cc @GabiHExpensify

@melvin-bot
Copy link

melvin-bot bot commented Oct 28, 2022

Auto-assign attempt failed, all eligible assignees are OOO.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 1, 2022
@Luke9389
Copy link
Contributor

Luke9389 commented Nov 2, 2022

We want this design doc to be reviewed ASAP because it's a fast change that dramatically improves our app. Also it's been lumped into WAQ (WhatsApp Quality) so the level of urgency is high (n7 to be specific).

@roryabraham
Copy link
Contributor

I have read and reviewed this Design Doc!

@melvin-bot
Copy link

melvin-bot bot commented Nov 2, 2022

👋 Hello Generalist Track Team - you have been assigned to review this High Level Design Doc. Please, treat this as a priority. Review this Stack Overflow for some tips on reviewing a design doc. Once you are done, simply press the Add "Reviewed Doc" comment button in the right hand side K2 pannel or follow these instructions.


@melvin-bot melvin-bot bot removed the DesignDocReview Autoassigner for design doc reviews label Nov 2, 2022
@trentpetty
Copy link

I have read and reviewed this Design Doc!

3 similar comments
@dangrous
Copy link
Contributor

dangrous commented Nov 3, 2022

I have read and reviewed this Design Doc!

@nathanmetcalf
Copy link
Contributor

I have read and reviewed this Design Doc!

@mountiny
Copy link
Contributor

mountiny commented Nov 3, 2022

I have read and reviewed this Design Doc!

@StefStavri
Copy link

I have read and reviewed this design doc

@mountiny mountiny reopened this Nov 4, 2022
@trjExpensify
Copy link
Contributor

I have read and reviewed this Design Doc!

1 similar comment
@JmillsExpensify
Copy link

I have read and reviewed this Design Doc!

@shannonmccallexfy
Copy link

I have read and reviewed this design doc

@RobertLadue
Copy link

I have read and reviewed this Design Doc!

@ryanschaffer
Copy link

Whoops, I reviewed this 2 weeks ago and didn't comment.

@ryanschaffer
Copy link

I have read and reviewed this Design Doc!

1 similar comment
@anmurali
Copy link

I have read and reviewed this Design Doc!

@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2022
@grgia
Copy link
Contributor

grgia commented Dec 12, 2022

Still in progress! Right now we're fixing the last few dark-mode/font bugs and TestRail QA for Applause

@JmillsExpensify
Copy link

Out of curiosity, why are we keeping this main issue open if the initial implementation is now complete? I think it's great that we already have a bunch of follow-on issues to track bugs, I just thought that everything from the initial push was already done. Is that right, and if so, how about closing this issue?

@grgia
Copy link
Contributor

grgia commented Dec 29, 2022

I think because we're still waiting on text inputs to get merged

@JmillsExpensify
Copy link

Gotcha, thanks for pulling out that PR. Hopefully we can close the loop on that one when everyone returns next week, and at that point, close this individual issue out.

@Luke9389
Copy link
Contributor

Luke9389 commented Jan 4, 2023

I'm iterating on reviews for Text Inputs daily. Hoping to see it merged soon!

@shawnborton
Copy link
Contributor Author

I think we can close this one out since the text inputs have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests