-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ExpensifyHelp to Match New Dot Styles #12446
Comments
Also might need to update |
workin on this one this week. PR is pretty much there, just held on some font PRs. |
Still prioritizing the other PRs over this one right now. |
Going to be working on this one today. It looks like there's an unresolved issue with the new fonts on android, so it's possible the same fix will need to be applied here once it's found. |
Finally resolved the jekyll error I was experiencing. I'll commit the fix w this PR. |
This issue has not been updated in over 15 days. @Luke9389 eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Tracking Issue: #12251
Design Doc Section: https://docs.google.com/document/d/197fXHLlHM_RJA4-3MITwdu0N5e0HX5Q74sA4W80YMD8/edit#bookmark=id.wectpruo06vv
Update ExpensifyHelp
We also need to update the styles on the ExpensifyHelp site. All of the code for this site is in the App/docs/ directory. It has its own style sheets in App/docs/_sass/, which need to be replaced. We can’t use the same styles that we use in the App because ExpensifyHelp is not made with React Native. It’s just a web page, so we opted to use vanilla JS. This means that the scss files for ExpensifyHelp use actual css syntax, where the styles.js file used in App uses json.
The text was updated successfully, but these errors were encountered: