Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ExpensifyHelp to Match New Dot Styles #12446

Closed
Luke9389 opened this issue Nov 3, 2022 · 6 comments
Closed

Update ExpensifyHelp to Match New Dot Styles #12446

Luke9389 opened this issue Nov 3, 2022 · 6 comments
Assignees
Labels
Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review

Comments

@Luke9389
Copy link
Contributor

Luke9389 commented Nov 3, 2022

Tracking Issue: #12251
Design Doc Section: https://docs.google.com/document/d/197fXHLlHM_RJA4-3MITwdu0N5e0HX5Q74sA4W80YMD8/edit#bookmark=id.wectpruo06vv

Update ExpensifyHelp

We also need to update the styles on the ExpensifyHelp site. All of the code for this site is in the App/docs/ directory. It has its own style sheets in App/docs/_sass/, which need to be replaced. We can’t use the same styles that we use in the App because ExpensifyHelp is not made with React Native. It’s just a web page, so we opted to use vanilla JS. This means that the scss files for ExpensifyHelp use actual css syntax, where the styles.js file used in App uses json.

Screen Shot 2022-11-03 at 12 36 05 PM

@Luke9389 Luke9389 added Weekly KSv2 Improvement Item broken or needs improvement. labels Nov 3, 2022
@Luke9389 Luke9389 self-assigned this Nov 3, 2022
@roryabraham
Copy link
Contributor

Also might need to update App/docs/assets/images with the new image assets 🙂

@Luke9389
Copy link
Contributor Author

workin on this one this week. PR is pretty much there, just held on some font PRs.

@melvin-bot melvin-bot bot removed the Overdue label Nov 14, 2022
@melvin-bot melvin-bot bot added the Overdue label Nov 23, 2022
@Luke9389
Copy link
Contributor Author

Still prioritizing the other PRs over this one right now.

@melvin-bot melvin-bot bot removed the Overdue label Nov 29, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2022
@Luke9389
Copy link
Contributor Author

Going to be working on this one today. It looks like there's an unresolved issue with the new fonts on android, so it's possible the same fix will need to be applied here once it's found.

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2022
@Luke9389
Copy link
Contributor Author

Finally resolved the jekyll error I was experiencing. I'll commit the fix w this PR.

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Dec 15, 2022
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Jan 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 9, 2023

This issue has not been updated in over 15 days. @Luke9389 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@Luke9389 Luke9389 closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Item broken or needs improvement. Monthly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants