BUG: default avatar different for new chat and In LHN reported by @gadhiyamanan

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. click on :green-plus-button: icon
2. select new chat
3. search for random new user ( like g1@gmail.com)
4. check the avatar (avatar background color)
5. click on the user to initiate conversation
6. check the avatar (avatar background color) on the conversation or LHN

Expected Result:

default avatar should be same while searching for new chat and LHN

Actual Result:

default avatars are different

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.18-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Screen.Recording.2022-10-19.at.11.26.48.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation:
https://expensify.slack.com/archives/C01GTK53T8Q/p1666160339859479
View all open jobs on GitHub

Recording.732.mp4

[melvin-bot]

Triggered auto assignment to @ntrepanier (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

@ntrepanier Eep! 4 days overdue now. Issues have feelings too...

[ntrepanier]

I tried to recreate the issue following the listed steps on android and web in both production and staging but could not reproduce.

[melvin-bot]

@ntrepanier Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@ntrepanier Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@ntrepanier Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@ntrepanier 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@ntrepanier 12 days overdue. Walking. Toward. The. Light...

[aldo-expensify]

Just noticed that there are some issues assigned to @ntrepanier , reapplying the AutoAssignerTriage!

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[sophiepintoraetz]

I'm able to reproduce

[grgia]

Not overdue, on hold

[grgia]

Oops melvin is bugging

[sophiepintoraetz]

What are we on hold for @grgia? Mind linking the GH its dependent on? That way we can close this issue and reopen it once the other is done

[grgia]

I was holding the avatar changes to complete core branding changes first. However that's almost done, so I should be able to work on avatar fixes again

[grgia]

Still holding, planning to work on avatars next week!

[grgia]

Adding reviewing label

[MelvinBot]

This issue has not been updated in over 15 days. @grgia, @sophiepintoraetz eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[grgia]

closing as completed, since no longer occurs with the new default avatars on new dot!

[gadhiyamanan]

@grgia @sophiepintoraetz can anyone reopen issue as reporting bonus is pending

[sophiepintoraetz]

@gadhiyamanan - I don't think you're eligible for a reporting bonus here, as we updated our brand on a wholesale level, which means the overall design of our chats have changed (i.e. there wasn't a specific PR to resolve this specific issue - the bug became obsolete once we changed the branding). I'm going to confirm this internally but wanted to let you know.

[gadhiyamanan]

I might be able to fix this while I implement the new avatars for new dot, I think we just need to match the hashing function in Web with the one in App. Mind if I assign for now @marcaaron ?

Please check #12022 (comment)

Cc: @sophiepintoraetz @grgia

[sophiepintoraetz]

See the following comment @gadhiyamanan - meaning that a PR was initially being scoped out but was superseded by the fact we were updating our branding anyways. Since the brand has been updated - a fix is no longer required. Correct me here, Georgia if I'm holding the wrong end of the stick!

I was holding the avatar changes to complete #12251 first. However that's almost done, so I should be able to work on avatar fixes again

[grgia]

You're correct @sophiepintoraetz we didn't end up needing to fix this, the bug was made obsolete by the brand change.

[sophiepintoraetz]

Thanks for confirming, Georgia. @gadhiyamanan - apologies but there is no reporting bonus to be issued here. I see you have been prolific in other areas, no doubt more will crop up for you to report!