[$500] [HOLD for payment 2023-09-07] - Group chat - Selecting a user with tab adds the first user in the list as well reported by @huzaifa-99

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on the plus icon and select new group chat
2. On the group chat creation menu, Tab to a user after the first user (lets say tab to user-2 that is after user-1)
3. Then Enter to select that user (user-2) as chat participant
4. Notice the previous user (user-1) is also selected as a chat participant

Expected Result:

Only the selected (Tab+Enter’ed) user should be added as chat participant

Actual Result:

The previously tabbed user (or the first user in the list) is also added as a chat participant

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.27-0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.887.mp4

Selecting.a.user.with.tab.after.the.first.in.users.list.selects.as.extra.user.as.a.chat.participant.during.new.group.chat.creation.-.Screen.Recording.2022-11-11.at.3.17.03.AM.mp4

Expensify/Expensify Issue URL:
Issue reported by: @huzaifa-99
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668120797180049

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014b28f9ab1fce6c44
• Upwork Job ID: 1699654638568853504
• Last Price Increase: 2023-09-07

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[kadiealexander]

Keeping on hold as mentioned. @mountiny could you please explain the hold here for context?

[mountiny]

Apologies, I should have commented before. AS listed in the title this is on hold for #11795 which is tracking similar issues related to option list selectors like this one. We plan to take a step back and predesign how this should behave and look throughout the App.

[kadiealexander]

Sounds good, thank you!

[kadiealexander]

Still on hold, Melvin.

[kadiealexander]

Movement is happening on the PR that is holding this up.

[kadiealexander]

Not overdue.

[kadiealexander]

@mountiny I can't see any latest updates in the linked issue, could you please give me a rough idea of what's happening here?

[mountiny]

Yeah so this will be on hold for WAQ and then we need to design how the option lists should work across the App and this navigation would be in there I think you can make this Monthly just fine 🙌

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[kadiealexander]

Not overdue.

[mountiny]

Ready for payment

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014b28f9ab1fce6c44

[melvin-bot]

Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[kadiealexander]

Sorry @mollfpr was just needing the Upwork link!

[kadiealexander]

@huzaifa-99 please let me know when you've accepted the offer!

[huzaifa-99]

@kadiealexander I accepted the offer. Thank you!

[thiagobrez]

@mountiny There's a small issue here. I could easily replace the list with the new component to fix the mentioned bug, but that would imply the New Group list following the new designs. @shawnborton mentioned here and here that we shouldn't use it for the New Group page yet.

Shawn, sorry for bothering again with this. Do we have any updates, or how do you guys want to proceed?

As a last resort I could leave the old list component and just apply the patch to make the Tab selection work correctly, but I don't think that's ideal. I would prefer transitioning to the new component in as many places as possible, so we could deprecate/remove the old one sooner and avoid two sources of bugs.

[mountiny]

@thiagobrez I actually think it might be worth waiting for an updated global create in this case. I think you can focus on other tasks in the refactor and this one leave for later, we will pay this out for reporting and rest can be discussed on your issue, I think

[thiagobrez]

Works for me @mountiny. Just a final clarification, so I should also hold on the New Chat replacement, because there will be a global create for both chats and groups, right?

[mountiny]

Yes

[shawnborton]

Shawn, sorry for bothering again with this. Do we have any updates, or how do you guys want to proceed?

No updates, let's keep on doing business as usual.

[kadiealexander]

Payouts due:

Issue Reporter: $250 @huzaifa-99

Upwork job is here.