LOW: [$500] Selection List Refactor: Simple Selection List

[thiagobrez]

This issue keeps track of Phase 3 of the Selection List Refactor, in which we are refactoring all different list component variations into 3 new, clean components:

• Phase 1: Radio Button List
• Phase 2: Checkbox List
• Phase 3: Simple Selection List (this phase)

Thoroughly discussed in the parent issue: #11795 (comment)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a737edd58e0c740d
• Upwork Job ID: 1698702807486967808
• Last Price Increase: 2023-09-04

Issue Owner

Current Issue Owner: @cristipaval

[thiagobrez]

I imagine I will be able to start on this next week.

[cristipaval]

I forgot to assign you to the issue, @thiagobrez . Sorry for that

[cristipaval]

I'll set this one on hold until the second phase is done.

[thiagobrez]

Starting to investigate this today, while second phase PR is in review

[thiagobrez]

Good news, these lists are fitting well with the new components. Group members list is ready

[thiagobrez]

Update: New Chat list is ready. Will be OOO for the rest of the week, so I'll come back to this on Monday

[thiagobrez]

Hi @shawnborton!

Context:

This issue is Phase 3 of the lists refactor (simple lists, no selection). One of these lists is the New Chat list (image below) ⬇️

Question:

This list is being reused for both New Chat and New Group lists. So I was wondering if maybe you have an update if I can proceed with the New Group list? Last time it was blocked (here) because you still needed to investigate the patterns around checkbox lists.

If there is not a decision on the New Group list yet, no problem, I can make it just for the New Chat list. I'm just checking because if I could change both at the same time, it would make it simpler :)

Thanks!

[shawnborton]

No progress there yet, so let's keep the New Group how it is for now.

[thiagobrez]

Perfect, thanks for the quick response!

[thiagobrez]

Update: Phase 3 is almost finished, will probably already raise the PR once Phase 2 is merged.

All previously investigated lists by Arek #11795 (comment) were already replaced (with one exception: SearchPage), but I see some lists were missed from the initial investigation (regarding all phases), so I will be adding those here as well.

1. SearchPage is currently being migrated to functional component, so I'm waiting this PR to be merged first before replacing the list

2. Lists in these pages were missed from the initial investigation, so I will be replacing them in this Phase:

• NotificationsPreferencePage
• WriteCapabilityPage
• TaskAssigneeSelectorModal
• TaskShareDestinationSelectorModal
• MoneyRequestConfirmationList
• IOUCurrencySelection
• MoneyRequestParticipantsSplitSelector

[thiagobrez]

Update: Phase 3 is almost finished, will probably already raise the PR once Phase 2 is merged.

[thiagobrez]

Update: Phase 3 is almost finished, will probably already raise the PR once Phase 2 is merged.

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @cristipaval, @rushatgabhane, @lukemorawski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[rushatgabhane]

Last PR to go! 🚀

PRs so far

• 20354 money request participants selector list refactoring #32692
• 20354 task assignees list refactor #35841
• SearchPage list refactor #33080
• 20354 task assignees list refactor #34978
• New chat page list refactor 2 #38610
• 20354 task share destination selector refactor #35413
• 20354 category picker list refactor #35567
• BaseShareLogList list refactor #38942
• Workspace switcher page list refactor #40179
• feat: refactor MoneyRequestConfirmationList #40785

[quinthar]

Should this be closed? If not, what is the next step, who is doing it, and when?

[MrMuzyk]

@quinthar Hey, so we have a PR that is waiting to be reviewed and tested again. After this is merged then whole refactor is complete and this issue can be closed.

Note: PR has been opened for 3 weeks now but it was hanging due to merge freeze I guess. In the meantime a new feature has been merged (uneven splits) that did some major changes in the refactored component and added a new feature to deprecated component that was being removed in this PR. I had to start pretty much from scratch thus the request to review and test it again before merging.

[rushatgabhane]

yep, it was reviewed 2 weeks ago but then a new feature was added in the deprecated component. Need to re-review now

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

This issue has not been updated in over 15 days. @JmillsExpensify, @cristipaval, @rushatgabhane, @lukemorawski eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[JmillsExpensify]

Can we close this issue out yet?

[MrMuzyk]

Refactor is complete. I'm fine closing it.

[laurenreidexpensify]

Payment Summary:

C+ Review

@rushatgabhane

• see LOW: [$500] Selection List Refactor: Simple Selection List #20354 (comment)
  • 8 * PRs @ $500 (before price change)
  • 2 * PRS @ $250 (after price change)

Total: $4500

Payment Method: Please request in Newdot

Contributor

@lukemorawski Agency contributor, no payment owed

[JmillsExpensify]

$4,5000 approved for @rushatgabhane