20354 money request participants selector list refactoring #32692

lukemorawski · 2023-12-07T18:02:28Z

Details

This PR refactors the MoneyRequestParticipantSelector and MoneyRequestParticipantPage to use new <SelectionList /> component.
Some other changes had been made, like moving some logic to useMemo hooks instead of invalid useEffect->useState pattern.
A new param has been added to <SelectionList /> to allow it to display a component on the right hand side of each list item. This param allows to pass a react node or a function that will render a component.

Fixed Issues

$ #20354
PROPOSAL: no proposal (draft pr)

Tests

same as QA steps
Verify that no errors appear in the JS console

Offline tests

same as QA steps

QA Steps

Tap FAB on home page and select "Request Money"
Select manual, fill in the amount and press "Next"
A list of users/workspaces will appear
Tap on list item to create an IOU
Or tap on "Split" button on the list item to create a "split"
add more items from the list
verify that everything works like in the production app
Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…refactoring

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

Co-authored-by: Agata Kosior <agata.kosior57@gmail.com>

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js

…rticipantsSelector.js Co-authored-by: VickyStash <vikstash@gmail.com>

src/components/SelectionList/BaseListItem.js

Co-authored-by: Michael (Mykhailo) Kravchenko <rezkiy37@gmail.com>

melvin-bot · 2023-12-08T16:36:56Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-12-11T03:50:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-01-10.at.12.12.59.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-01-10.at.12.18.32.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-01-08.at.18.02.46.mov

MacOS: Desktop

…refactoring

lukemorawski · 2024-01-10T11:03:20Z

@rushatgabhane fixed conflicts

cristipaval · 2024-01-10T12:21:46Z

@lukemorawski and @rushatgabhane , Could you please make sure that the author and reviewer checklists pass?

OSBotify · 2024-01-11T13:35:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

youssef-lr · 2024-01-12T00:59:21Z

hey @lukemorawski - it seems like onChangeText is not debounced in BaseSelectionList, can we get this fixed please before this become a deployer blocker? For reference.

I'm also noticing a flicker of the skeleton appearing, which doesn't show up in the SearchPage or NewChatPage, not sure if this is a feature or bug.

Screen.Recording.2024-01-12.at.01.57.42.mov

lukemorawski · 2024-01-12T08:52:11Z

@youssef-lr on it!

lukemorawski · 2024-01-12T11:27:29Z

@youssef-lr can you create an ticket from this comment, or should I just create a new PR and mention it here?

youssef-lr · 2024-01-12T11:29:32Z

The latter seems fine!

lukemorawski · 2024-01-12T14:16:53Z

@youssef-lr here's the quick fix PR
#34443

OSBotify · 2024-01-15T11:56:47Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

parasharrajat · 2024-01-16T13:24:09Z

src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

+ maxParticipantsReached,
+ _.some(participants, (participant) => participant.searchText.toLowerCase().includes(searchTerm.trim().toLowerCase())),
+ ),
+ [maxParticipantsReached, newChatOptions.personalDetails.length, newChatOptions.recentReports.length, newChatOptions.userToInvite, participants, searchTerm],


This logic is crashing...when I select more than 5 participants on request money Can not read personalDetails of undefined.

any steps to reproduce the crash? cause I had no crashes at all

Request money.

set 7 $.

Select 8 participants.

Notice the crash.

yep, got it. PR with a fix is on it's way. Should I just mention it here and tag you in the comment, or will there be a new ticket for it?

You can create the PR. I will mention the same on the current issue.

lukemorawski · 2024-01-16T15:51:52Z

@parasharrajat here's the quick fix PR #34587

rushatgabhane · 2024-01-16T15:52:46Z

Thank you @lukemorawski @parasharrajat
I'll review it.

edit: all done and merged

OSBotify · 2024-01-17T01:14:31Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.25-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

lukemorawski and others added 12 commits November 29, 2023 16:02

useEffects refactoring

5737385

logic refactoring

fec08cf

fixes

ddd5695

Merge branch 'main' into 20354-MoneyRequestParticipantsSelector_list_…

e101119

…refactoring

styling fixes

40c3b74

refactored to split button

9c4b4b8

ref refactoring

e5489e9

removed unnecessary import

7bfc447

removed comment

c2f869e

Merge branch 'main' into 20354-MoneyRequestParticipantsSelector_list_…

f36e36a

…refactoring

Merge branch 'main' into 20354-MoneyRequestParticipantsSelector_list_…

47812b1

…refactoring

prettier

ae3ed97

koko57 reviewed Dec 8, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js Show resolved Hide resolved

koko57 reviewed Dec 8, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js Outdated Show resolved Hide resolved

koko57 reviewed Dec 8, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js Outdated Show resolved Hide resolved

lukemorawski and others added 4 commits December 8, 2023 16:08

iouType from CONST

3b161c6

Co-authored-by: Agata Kosior <agata.kosior57@gmail.com>

cleaner right hand side component rendering syntax

e294815

removed unused prop

8b4d2e5

offline message cleaner syntax

2790197

VickyStash reviewed Dec 8, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSelector.js Outdated Show resolved Hide resolved

Update src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestPa…

099049b

…rticipantsSelector.js Co-authored-by: VickyStash <vikstash@gmail.com>

rezkiy37 reviewed Dec 8, 2023

View reviewed changes

src/components/SelectionList/BaseListItem.js Outdated Show resolved Hide resolved

lukemorawski and others added 2 commits December 8, 2023 17:25

Update src/components/SelectionList/BaseListItem.js

6153e6a

Co-authored-by: Michael (Mykhailo) Kravchenko <rezkiy37@gmail.com>

lint

98ed390

lukemorawski marked this pull request as ready for review December 8, 2023 16:36

lukemorawski requested a review from a team as a code owner December 8, 2023 16:36

melvin-bot bot requested review from rushatgabhane and removed request for a team December 8, 2023 16:36

melvin-bot bot requested a review from cristipaval January 10, 2024 06:52

Merge branch 'main' into 20354-MoneyRequestParticipantsSelector_list_…

55b2c46

…refactoring

lukemorawski requested a review from rushatgabhane January 10, 2024 11:03

rushatgabhane approved these changes Jan 10, 2024

View reviewed changes

rushatgabhane approved these changes Jan 11, 2024

View reviewed changes

cristipaval approved these changes Jan 11, 2024

View reviewed changes

cristipaval merged commit 5901e1c into Expensify:main Jan 11, 2024
16 of 19 checks passed

hoangzinh mentioned this pull request Jan 12, 2024

[IOU] - Fix Error bypass in Participants Page on CMD+Enter #34109

Closed

49 tasks

lukemorawski mentioned this pull request Jan 12, 2024

20354 money request participants selector skeleton fix #34443

Closed

53 tasks

brunovjk mentioned this pull request Jan 12, 2024

Fix Black Screen Transition Issue by Reusing didScreenTransitionEnd in MoneyRequestParticipantsSelector #32665

Merged

50 tasks

github-actions bot mentioned this pull request Jan 15, 2024

Deploy Checklist: New Expensify 2024-01-15 #34493

Closed

83 tasks

bernhardoj mentioned this pull request Jan 15, 2024

[HOLD for payment 2024-01-25] [HOLD for payment 2024-01-24] Referral - Info icon in Referral banner is black in dark mode #34501

Closed

6 tasks

FitseTLT mentioned this pull request Jan 15, 2024

[HOLD for payment 2024-01-25] [HOLD for payment 2024-01-24] [$250] Split - Checkmark is not displayed when clicking on Split next to the user #34503

Closed

6 tasks

parasharrajat reviewed Jan 16, 2024

View reviewed changes

parasharrajat mentioned this pull request Jan 16, 2024

LOW: [$500] Selection List Refactor: Simple Selection List #20354

Closed

lukemorawski mentioned this pull request Jan 16, 2024

[CP Staging] Fix App crash when selecting more than 5 participants #34587

Merged

54 tasks

BhuvaneshPatil mentioned this pull request Mar 5, 2024

[$500] Web - Errors appear in the JS console when requesting money or assigning a task #32605

Closed

6 tasks

c3024 mentioned this pull request May 7, 2024

[C+ Checklist Needs Completion] CRITICAL: [Actionable Whispers] [$250] Categorize it - No workspace found appears briefly after clearing search field #40520

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

20354 money request participants selector list refactoring #32692

20354 money request participants selector list refactoring #32692

lukemorawski commented Dec 7, 2023 •

edited

Loading

melvin-bot bot commented Dec 8, 2023

rushatgabhane commented Dec 11, 2023 •

edited

Loading

lukemorawski commented Jan 10, 2024

cristipaval commented Jan 10, 2024

OSBotify commented Jan 11, 2024

youssef-lr commented Jan 12, 2024 •

edited

Loading

lukemorawski commented Jan 12, 2024

lukemorawski commented Jan 12, 2024

youssef-lr commented Jan 12, 2024

lukemorawski commented Jan 12, 2024

OSBotify commented Jan 15, 2024

parasharrajat Jan 16, 2024 •

edited

Loading

lukemorawski Jan 16, 2024

parasharrajat Jan 16, 2024

lukemorawski Jan 16, 2024

parasharrajat Jan 16, 2024

lukemorawski commented Jan 16, 2024

rushatgabhane commented Jan 16, 2024 •

edited

Loading

OSBotify commented Jan 17, 2024

20354 money request participants selector list refactoring #32692

20354 money request participants selector list refactoring #32692

Conversation

lukemorawski commented Dec 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 8, 2023

rushatgabhane commented Dec 11, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

lukemorawski commented Jan 10, 2024

cristipaval commented Jan 10, 2024

OSBotify commented Jan 11, 2024

youssef-lr commented Jan 12, 2024 • edited Loading

lukemorawski commented Jan 12, 2024

lukemorawski commented Jan 12, 2024

youssef-lr commented Jan 12, 2024

lukemorawski commented Jan 12, 2024

OSBotify commented Jan 15, 2024

parasharrajat Jan 16, 2024 • edited Loading

Choose a reason for hiding this comment

lukemorawski Jan 16, 2024

Choose a reason for hiding this comment

parasharrajat Jan 16, 2024

Choose a reason for hiding this comment

lukemorawski Jan 16, 2024

Choose a reason for hiding this comment

parasharrajat Jan 16, 2024

Choose a reason for hiding this comment

lukemorawski commented Jan 16, 2024

rushatgabhane commented Jan 16, 2024 • edited Loading

OSBotify commented Jan 17, 2024

lukemorawski commented Dec 7, 2023 •

edited

Loading

rushatgabhane commented Dec 11, 2023 •

edited

Loading

youssef-lr commented Jan 12, 2024 •

edited

Loading

parasharrajat Jan 16, 2024 •

edited

Loading

rushatgabhane commented Jan 16, 2024 •

edited

Loading