Fix Black Screen Transition Issue by Reusing didScreenTransitionEnd in MoneyRequestParticipantsSelector

[brunovjk]

Details

Reuse didScreenTransitionEnd to address the screen transition skeleton issue

Fixed Issues

$ 31779
PROPOSAL: #31779 (comment)

Tests

1. Use a 'High Traffic' account, or any account with a large contact list.
2. Access the FAB and select "Request money."
3. Add an amount and click "Next" to initiate the transition.
4. Observe the screen transition from .../manual to the ../participants.
5. Verify that the black screen issue no longer occurs during the transition.
6. Confirm that no errors are present during the screen transition skeleton.

• Verify that no errors appear in the JS console

Offline tests

Same as Tests.

• Verify that no errors appear in the JS console

QA Steps

Same as Tests.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android_.Native.mp4

Android: mWeb Chrome

Android_.mWeb.Chrome.mp4

iOS: Native

iOS_.Native.mp4

iOS: mWeb Safari

iOS_.mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS_.Chrome._.Safari.mp4

MacOS: Desktop

MacOS_.Desktop.mp4

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[brunovjk]

I have read the CLA Document and I hereby sign the CLA

[melvin-bot]

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[grgia]

@ntdiary assigned for review

[situchan]

@brunovjk your branch is very behind. The 2 components you made changes on are now deprecated.

[brunovjk]

The 2 components you made changes on are now deprecated.

@situchan the refactored money request navigation was merged but the initial issue remains. We can apply the same solution proposed previously.

I updated this PR to apply changes at new components used. Also update the video screenshot.

[ntdiary]

For native platforms, the current implementation seems to be not perfect yet. We can still see a black screen below the input field (without skeleton). It seems that the onLayout event is triggered late ?.

App/src/components/OptionsListSkeletonView.js

Line 100 in bc62838

onLayout={(event) => {

ios-native.mp4

[melvin-bot]

🎯 @ntdiary, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #34818.

[brunovjk]

Thank you very much @ntdiary, I really appreciate your patience and goodwill :D
Now just wait for @grgia?

[ntdiary]

Thank you very much @ntdiary, I really appreciate your patience and goodwill :D Now just wait for @grgia?

Yeah. :)

cc @grgia

[lakchote]

Lint tests are failing. Could you please fix it @brunovjk?

Other than that, LGTM 👍 thanks for your contribution @brunovjk and your comments/tests @ntdiary.

[ntdiary]

32665-test.mp4

retest due to merging the main branch, and it looks good. Additionally, found a unrelated crash and left a comment in their PR. :)

The TS error seems unrelated to this PR as well.

[brunovjk]

I think is fixed :D
"Jack
This is fixed now, please merge main in your PRs! #slack_conversation"

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.33-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅