[HOLD for payment 2024-01-25] [HOLD for payment 2024-01-24] [$250] Split - Checkmark is not displayed when clicking on Split next to the user

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.25-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Go to FAB > Request money > Manual
2. Enter amount and proceed to participant selection page
3. Search for a user with no chat history
4. Click Split

Expected Result:

Checkmark is displayed when clicking on Split next to the user

Actual Result:

Checkmark is not displayed when clicking on Split next to the user

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6342987_1705329271340.20240115_202002__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b5d32ee19b7bd5d4
• Upwork Job ID: 1746941516473966592
• Last Price Increase: 2024-01-15
• Automatic offers:
• FitseTLT | Contributor | 28103739

Issue Owner

Current Issue Owner: @twisterdotcom

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b5d32ee19b7bd5d4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Upwork job price has been updated to $250

[suneox]

Can not reproduce on v1.4.25-2

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Checkmark is not displayed when clicking on Split next to the user

What is the root cause of that problem?

It is caused by #32692 . Because we are passing includeSelectedOptions as true to getFilteredOptions here

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Lines 123 to 124 in a4e3ae2

	true,
	);

so it is included to the normal (unselected) options returned from getFilteredOptions and it will be excluded from selected options as it will be filetered out here

App/src/libs/OptionsListUtils.js

Lines 1958 to 1960 in a4e3ae2

	const isReportInPersonalDetails = _.some(filteredPersonalDetails, (personalDetail) => personalDetail.accountID === accountID);
	return isPartOfSearchTerm && !isReportInRecentReports && !isReportInPersonalDetails;
	});

Before it worked this way because we give selectedOptions to the OptionsSelector but now with SectionsList we need to pass the selected sections along with other sections and selected sections are getting filtered out for the reason above.

What changes do you think we should make in order to solve the problem?

pass false to includeSelectedOptions for getFilteredOptions

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Lines 123 to 124 in a4e3ae2

	true,
	);

to
false

What alternative solutions did you explore? (Optional)

[FitseTLT]

UPdated to include more explanation

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Assigning @FitseTLT to get this going, please raise a PR with urgency

[dukenv0307]

Can't reproduce this on the latest main.

[lukemorawski]

yep, not reproducible on current main

[FitseTLT]

@lukemorawski you are selecting a user from recent section (you should select from Contacts section) 👍

[lukemorawski]

@FitseTLT oddly, when searching for something, "Contacts" section vanishes and only "Recents" are available (with users from Contacts showing up in those new recents).
So still can't reproduce this. Though, looks like your proposed solution should do the trick.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.25-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix - Checkmark is not displayed when clicking on Split next to the user #34562

If no regressions arise, payment will be issued on 2024-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix - Checkmark is not displayed when clicking on Split next to the user #34562

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @FitseTLT requires payment automatic offer (Contributor)

[FitseTLT]

@mountiny Payment Overdue

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

$250 to @FitseTLT

and $250 to @allroundexperts

[twisterdotcom]

Payment Summary:

• @FitseTLT paid $250 here
• @allroundexperts paid $250 via newDot requests.

[allroundexperts]

@twisterdotcom I get paid through the App. You can cancel my upwork invitation. Thanks

[twisterdotcom]

Ah! Of course. Okay. Hang on, will cancel and update the Payment Summary.

[JmillsExpensify]

$250 approved for @allroundexperts based on this summary.