[C+ Checklist Needs Completion] CRITICAL: [Actionable Whispers] [$250] Categorize it - No workspace found appears briefly after clearing search field

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: no, this is a new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Track expense.
3. Create a track manual expense.
4. Select Categorize it from the whisper.
5. Enter an invalid string in the search field.
6. Clear the search field.

Expected Result:

In step 5: The error message should appear when entering the invalid string
In step 6: Workspace list will show up immediately after clearing the search field.

Actual Result:

In step 5: Nothing showing to indicate for no results found
In step 6: Workspace list empty state (No workspace found) appears briefly after clearing the search field.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6454146_1713466866957.bandicam_2024-04-18_23-33-12-401.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b97ed1aa9534847a
• Upwork Job ID: 1781102371560218624
• Last Price Increase: 2024-04-18
• Automatic offers:
• c3024 | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kavimuru]

We think this bug might be related to #wave-collect - Release 1

[thienlnam]

Will take this one since it's related to track

[thienlnam]

Doesn't look like it needs to be a blocker

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b97ed1aa9534847a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense- Categorize it - No workspace found appears briefly after clearing search field

What is the root cause of that problem?

We flash the not found page even when the search term is empty as there are no search results:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 381 in 985591f

if ([CONST.IOU.ACTION.CATEGORIZE, CONST.IOU.ACTION.SHARE].includes(action) && isAllSectionsEmpty && didScreenTransitionEnd && searchTerm.trim() === '') {

This results in current behavior.

What changes do you think we should make in order to solve the problem?

We should check if the user actually has workspaces by adding a check for active Policies:

&&  !Policy.hasActiveChatEnabledPolicies(allPolicies)

here:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 381 in 985591f

if ([CONST.IOU.ACTION.CATEGORIZE, CONST.IOU.ACTION.SHARE].includes(action) && isAllSectionsEmpty && didScreenTransitionEnd && searchTerm.trim() === '') {

[gijoe0295]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No workspace found appears briefly after clearing search field

What is the root cause of that problem?

This condition changes immediately when searchTerm changes:

App/src/pages/iou/request/MoneyTemporaryForRefactorRequestParticipantsSelector.js

Line 381 in c7cd851

if ([CONST.IOU.ACTION.CATEGORIZE, CONST.IOU.ACTION.SHARE].includes(action) && isAllSectionsEmpty && didScreenTransitionEnd && searchTerm.trim() === '') {

On the other hand, we used debouncedSearchTerm to compute sections. That caused an un-synchronization. Initially, sections was empty when results contain nothing, then when user deleted the search, searchTerm immediately changed to empty first while debouncedSearchTerm has not and thus sections has not been re-computed. At this moment, both sections and searchTerm is empty causing the empty workspace view to render.

What changes do you think we should make in order to solve the problem?

Replace the condition above with debouncedSearchTerm.

What alternative solutions did you explore? (Optional)

NA

[neonbhai]

Proposal updated

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @c3024

[quinthar]

Wow great!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix no result found doesn't show when the search found nothing in categorize expense #40748

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @c3024 requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[greg-schroeder]

@c3024 All that's left is the checklist and we can close this out!

[melvin-bot]

@greg-schroeder, @thienlnam, @bernhardoj, @c3024 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: 20354 money request participants selector list refactoring #32692
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: bernhardoj@9c79b10#r141745523
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion started because no specific steps can be included in the checklist for early detection of the bug.
• [@c3024] Determine if we should create a regression test for this bug. Yes
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open your self DM chat
2. Track a new expense. Wait until the concierge message shows up
3. Choose Categorize it
4. Search for a text that matches with no workspace name but does with a user display name/login
5. Verify the No result found header message is shown with no results

👍 or 👎

[greg-schroeder]

Thanks @c3024 - filing regression test