[HOLD for payment 2022-12-20] While resizing, a white window background is shown

[Julesssss]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

• Resize the web browser window while in dark mode

Expected Result:

• No obvious white background colour should be displayed

Actual Result:

• An obvious white background colour is displayed

Screen.Recording.2022-11-24.at.11.42.55.mov

Platform:

Where is this issue occurring?

• Web ✅

Version Number:
Reproducible in staging?: True
Reproducible in production?: True soon
Email or phone of affected tester (no customers): all

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019db029d99d78265b
• Upwork Job ID: 1606391966285721600
• Last Price Increase: 2022-12-23

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[s77rt]

I think @shawnborton suggestion will fix this bug.
However if the theme can be dynamically changed an event listener will be required to update the body CSS

[adelekennedy]

@Julesssss this looks like a dupe of this issue here from this comment it sounds like @grgia is already working on this - should we close this issue?

[Julesssss]

Good spot, but based I think they might be separate issues. Let's keep them separate until the solutions come in

[grgia]

Are you working on this one @Julesssss ? I have a somewhat hacky fix that I'm looking for a better solution for this PR

[Julesssss]

Hey @grgia, nah I kept myself assigned in case this was made external, but feel free to take it over if you're working on a fix.

[melvin-bot]

@Julesssss, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[grgia]

Whoops, in review!

[Santhosh-Sellavel]

Please assign me this issue to track payment for this PR Review Thanks!

[adelekennedy]

assigned @Santhosh-Sellavel for PR review payment!

[francoisl]

The QA team sent this video, seems like we still show a white background on Windows. Any ideas or thoughts if we should make this a blocker?

13278.Web.mp4

[Santhosh-Sellavel]

@francoisl
On Mac, I don't get a white screen when I try to resize the browser or dragging, but I get to try to adjust the screen size in inspect mode. I am not sure we might be able to fix this.

On Staging

Screen.Recording.2022-12-10.at.12.14.50.AM.mov

On Local, unable to reproduce at all

Screen.Recording.2022-12-10.at.12.22.15.AM.mov

cc: @grgia

[francoisl]

Yeah same here, which makes me think it's somehow specific to Windows. Anyway, we can look into this later, let's not block the deploy for this.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Change background color for mWeb scrolling #13278

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel / @Julesssss / @grgia] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel / @Julesssss / @grgia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel / @Julesssss / @grgia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[Julesssss]

No need for regression test, this was not a regression but an improvement.

[Santhosh-Sellavel]

@grgia or @Julesssss can you add a bz here

[grgia]

Dragging you back @adelekennedy !!

[Santhosh-Sellavel]

@grgia seems @adelekennedy is on OOO can you assign someone else, thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019db029d99d78265b

[melvin-bot]

Current assignee @Santhosh-Sellavel is eligible for the Internal assigner, not assigning anyone new.

[mallenexpensify]

@Santhosh-Sellavel , can you accept plz https://www.upwork.com/jobs/~019db029d99d78265b

[Santhosh-Sellavel]

@mallenexpensify Done!

[mallenexpensify]

Paid @Santhosh-Sellavel $1000. Closing cuz I don't think we need regression test steps adds per @Julesssss 👎 above