-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$2000] mWeb/Safari - Chat - White space appears under compose box #13219
Comments
Triggered auto assignment to @dylanexpensify ( |
Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new. |
Job added to Upwork: https://www.upwork.com/jobs/~011f01f43f2f0d690b |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane ( |
Triggered auto assignment to @alex-mechler ( |
We should close this duplicate issue. It is being tackled at #13085. |
@parasharrajat I don't believe this is a duplicate of #13085. It might be a problem with the way the Safari keyboard works on iOS. You can read about it in this blog. https://blog.opendigerati.com/the-eccentric-ways-of-ios-safari-with-the-keyboard-b5aa3f34228d |
@grgia this would be fixed by changing the background color from white to green, right? If yes, we can hold this issue |
yes, I agree. Let's hold, for now. I should be able to get the fix done for the body color this week. |
not overdue @grgia shall we move to weekly? |
@alex-mechler, @sobitneupane, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
not overdue - on hold |
This comment was marked as off-topic.
This comment was marked as off-topic.
@someone-here I think your comment belongs on the other issue not here (I minimized it to avoid confusion). The issues look very similar to me. Also I think we should establish the root cause before suggesting that they require different solutions. |
Sorry for that, actually I was blocked from commenting on that issue, so I hope you understand. I agree with you we should look into the root cause of this and then determine if the issues are separate. Just waiting for the sign in issues to be fixed on web and then I'll look into it.... |
@grgia would you mind weighing in on why we put this on hold? thank you! |
Bump @grgia |
Yeah I agree, let's take this off hold |
Let's double this to get some fresh eyes now that we're off hold |
|
ProposalI think, we need to add background color to body element. I am not able to test this, as I am facing issue with login. Can you test this?
|
@mdneyazahmad Thanks for your proposal. The expected result is not just to change the color but to not have any extra spaces (that are not required) below compose box. |
@alex-mechler, @sobitneupane, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@alex-mechler, @sobitneupane, @dylanexpensify Still overdue 6 days?! Let's take care of this! |
@alex-mechler, @sobitneupane, @dylanexpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
I ran into this all over the place with mobile safari. It will happen anywhere that there is a keyboard and my theory is that it has to do with how mobile safari makes room for the keyboard. To make room, there is extra space added to the page. This works fine until you manually pull the page up and can see the extra space. You can see it very clearly on the sign-in page for example: This has also been reported in a couple of public SOs with no solutions:
Since this appears to be a bug inherent with mobile safari and beyond our control and there are no solutions for it that have been found on Google, then let's just close this as |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
No white space appears under compose box
Actual Result:
White space appears under compose box
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.34.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5842839_2022_11_30_23_55_Img_8342.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: