Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$2000] mWeb/Safari - Chat - White space appears under compose box #13219

Closed
kbecciv opened this issue Dec 1, 2022 · 28 comments
Closed

[$2000] mWeb/Safari - Chat - White space appears under compose box #13219

kbecciv opened this issue Dec 1, 2022 · 28 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Dec 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with any account
  3. Navigate to any conversation
  4. Focus on the compose box and scroll up

Expected Result:

No white space appears under compose box

Actual Result:

White space appears under compose box

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.2.34.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5842839_2022_11_30_23_55_Img_8342.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 1, 2022

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@dylanexpensify dylanexpensify added the External Added to denote the issue can be worked on by a contributor label Dec 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 1, 2022

Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.

@melvin-bot melvin-bot bot changed the title mWeb/Safari - Chat - White space appears under compose box [$1000] mWeb/Safari - Chat - White space appears under compose box Dec 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 1, 2022

Job added to Upwork: https://www.upwork.com/jobs/~011f01f43f2f0d690b

@melvin-bot
Copy link

melvin-bot bot commented Dec 1, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 1, 2022

Triggered auto assignment to @alex-mechler (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@parasharrajat
Copy link
Member

We should close this duplicate issue. It is being tackled at #13085.

@Delgee
Copy link
Contributor

Delgee commented Dec 1, 2022

@parasharrajat I don't believe this is a duplicate of #13085. It might be a problem with the way the Safari keyboard works on iOS. You can read about it in this blog. https://blog.opendigerati.com/the-eccentric-ways-of-ios-safari-with-the-keyboard-b5aa3f34228d

@rushatgabhane
Copy link
Member

rushatgabhane commented Dec 1, 2022

@grgia this would be fixed by changing the background color from white to green, right? If yes, we can hold this issue

@grgia
Copy link
Contributor

grgia commented Dec 1, 2022

yes, I agree. Let's hold, for now. I should be able to get the fix done for the body color this week.

@grgia grgia removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 1, 2022
@alex-mechler alex-mechler changed the title [$1000] mWeb/Safari - Chat - White space appears under compose box [HOLD][$1000] mWeb/Safari - Chat - White space appears under compose box Dec 1, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2022
@dylanexpensify
Copy link
Contributor

not overdue @grgia shall we move to weekly?

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 8, 2022

@alex-mechler, @sobitneupane, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Dec 8, 2022
@dylanexpensify
Copy link
Contributor

not overdue - on hold

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 8, 2022
@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2022
@marcaaron
Copy link
Contributor

Can someone summarize why this is on HOLD? Looking at this video - even if the background color gets updated there would still be a gap under the compose box that should not be there?

2022-12-13_07-19-46

@esh-g

This comment was marked as off-topic.

@marcaaron
Copy link
Contributor

marcaaron commented Dec 13, 2022

@someone-here I think your comment belongs on the other issue not here (I minimized it to avoid confusion). The issues look very similar to me. Also I think we should establish the root cause before suggesting that they require different solutions.

@esh-g
Copy link
Contributor

esh-g commented Dec 14, 2022

@someone-here I think your comment belongs on the other issue not here (I minimized it to avoid confusion). The issues look very similar to me. Also I think we should establish the root cause before suggesting that they require different solutions.

Sorry for that, actually I was blocked from commenting on that issue, so I hope you understand. I agree with you we should look into the root cause of this and then determine if the issues are separate. Just waiting for the sign in issues to be fixed on web and then I'll look into it....

@melvin-bot melvin-bot bot added the Overdue label Dec 14, 2022
@dylanexpensify
Copy link
Contributor

@grgia would you mind weighing in on why we put this on hold? thank you!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 14, 2022
@alex-mechler
Copy link
Contributor

Bump @grgia

@melvin-bot melvin-bot bot removed the Overdue label Dec 16, 2022
@grgia
Copy link
Contributor

grgia commented Dec 16, 2022

Yeah I agree, let's take this off hold

@grgia grgia changed the title [HOLD][$1000] mWeb/Safari - Chat - White space appears under compose box [$1000] mWeb/Safari - Chat - White space appears under compose box Dec 16, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 19, 2022
@dylanexpensify
Copy link
Contributor

Let's double this to get some fresh eyes now that we're off hold

@melvin-bot melvin-bot bot removed the Overdue label Dec 19, 2022
@dylanexpensify dylanexpensify changed the title [$1000] mWeb/Safari - Chat - White space appears under compose box [$2000] mWeb/Safari - Chat - White space appears under compose box Dec 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 19, 2022

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@mdneyazahmad
Copy link
Contributor

Proposal

I think, we need to add background color to body element.

I am not able to test this, as I am facing issue with login. Can you test this?

file: web/index.html

body {
   backgound-color: #000000; /* add the required color */
}

@sobitneupane
Copy link
Contributor

@mdneyazahmad Thanks for your proposal.

The expected result is not just to change the color but to not have any extra spaces (that are not required) below compose box.

@melvin-bot melvin-bot bot added the Overdue label Dec 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 22, 2022

@alex-mechler, @sobitneupane, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Dec 26, 2022

@alex-mechler, @sobitneupane, @dylanexpensify Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Dec 28, 2022

@alex-mechler, @sobitneupane, @dylanexpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@tgolen
Copy link
Contributor

tgolen commented Dec 28, 2022

I ran into this all over the place with mobile safari. It will happen anywhere that there is a keyboard and my theory is that it has to do with how mobile safari makes room for the keyboard. To make room, there is extra space added to the page. This works fine until you manually pull the page up and can see the extra space. You can see it very clearly on the sign-in page for example:

image

This has also been reported in a couple of public SOs with no solutions:

Since this appears to be a bug inherent with mobile safari and beyond our control and there are no solutions for it that have been found on Google, then let's just close this as won't fix. Also, the background color is no longer white either, so that's been fixed already:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests