Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-12-20] [HOLD for payment 2022-12-08] Profile - The tabs for "Preferred pronouns" or "Set my time zone automatically" are showing white spaces #13127

Closed
kavimuru opened this issue Nov 29, 2022 · 11 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Nov 29, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with any account
  3. Click on Profile
  4. Click on “Preferred Pronouns” or “Set my timezone automatically” option

Expected Result:

The "Preferred Pronouns" or "Set my time zone automatically" tabs should show a selection of pronouns and countries

Actual Result:

The tabs for "Preferred pronouns" or "Set my time zone automatically" are empty
NOTE: This is happening in the workspace list when creating rooms, Country selection

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • mweb - White background appears
  • Android

Version Number: 1.2.33-1
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5840049_Gravar__1813.mp4

https://user-images.githubusercontent.com/43996225/204540473-75357258-cf68-4585-b413-8662842bce11.mp4
image (1)
image

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Nov 29, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Nov 29, 2022

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Gonals
Copy link
Contributor

Gonals commented Nov 29, 2022

I'm not seeing this behavior. What browser are you using?
Screenshot 2022-11-29 at 4 43 56 PM

@luacmartins
Copy link
Contributor

I'm also not able to reproduce
Screenshot 2022-11-29 at 9 17 00 AM

@pecanoro
Copy link
Contributor

I tried to reproduce on Safari, working just fine as well.

Monosnap Monosnap 2022-11-29 14-23-52

@luacmartins
Copy link
Contributor

I confirmed that this happens on Windows Chrome

@mvtglobally
Copy link

@pecanoro @Gonals @luacmartins we are seeing the dropdown issue across multiple platforms and places. Should we log them individually or we can use this issue for tracking. See screenshots

Record_2022-11-29-23-32-46_4f9154176b47c00da84e32064abf1c48.mp4

image - 2022-11-29T173056 386
IMG_2894
Screenshot_2022-11-29-23-50-44-39_40deb401b9ffe8e1df2f1cc5ba480b12

@luacmartins
Copy link
Contributor

No need to log them individually, they all seem to have the same root cause. @pecanoro how's that PR coming along?

@luacmartins
Copy link
Contributor

This was fixed by #13174. Closing.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Dec 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 1, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-08. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot changed the title Profile - The tabs for "Preferred pronouns" or "Set my time zone automatically" are showing white spaces [HOLD for payment 2022-12-08] Profile - The tabs for "Preferred pronouns" or "Set my time zone automatically" are showing white spaces Dec 1, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 13, 2022
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2022-12-08] Profile - The tabs for "Preferred pronouns" or "Set my time zone automatically" are showing white spaces [HOLD for payment 2022-12-20] [HOLD for payment 2022-12-08] Profile - The tabs for "Preferred pronouns" or "Set my time zone automatically" are showing white spaces Dec 13, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 13, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-12-20. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants