Deploy Checklist: New Expensify 2022-11-28

[OSBotify]

Release Version: 1.2.33-7
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Update Concierge icon #12425
• Fix janky Android splash screen #12642
• [No QA] Trim .env values for iOS #12871
• Make the Switch to Dark Mode  #12944
• Have only one placeholder in the compose box #12988
• Show the report's old policy name if the workspace has been deleted #12993
• Fix CSP console error when staging website is loaded #13054
• Fix/12777: Attachment -The image can be dragged by moving the cursor outside the image #13077
• [NoQA] Fixes for mobile internal deploy + desktop job #13078
• [No QA] Clarify that proposals are only reviewed in GH #13081
• Remove unecessary todo line #13083
• Sort archived rooms using Unix epoch #13093
• fix android keyboard issue #13106
• Fix autofill styles #13119
• Dark Picker Icon Colour Scheme Added #13142
• Fix autofill colors #13164
• Add a color to the options in the picker when using Windows #13174

Deploy Blockers:

• [HOLD for payment 2022-12-08] Android -Chat - The compose field is covered by keyboard #13111
• [HOLD for payment 2022-12-08] Profile - If user uses saved information, background turns white & is very hard to read #13116
• [HOLD for payment 2022-12-20] [HOLD for payment 2022-12-08] Profile - The tabs for "Preferred pronouns" or "Set my time zone automatically" are showing white spaces #13127
• [$1000] Icons in VBA flow are very hard to see or white in dark mode #13132
• The message /report item should remain highlighted when context menu is being opened. #13139
• [HOLD for payment 2022-12-08] Web - Sign -The password is not visible in dark mode when you have autofill #13141
• [HOLD for payment 2022-12-08] Manually connecting a bank account is broken #13163

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.33-1 🚀

[marcaaron]

Put up a fix for the second deploy blocker listed here: #13119

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-2 🚀

[luacmartins]

Thanks for the fix @marcaaron

[arosiclair]

Closed #13139 as it is reproducible in prod

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-2 has been deployed to staging 🎉

[mvtglobally]

@luacmartins Regression is completed

PR #12944 (comment) Can we check off? Dark mode is definitely On
PR #13054 Error is not fixed.
PR #13119 There is no option to autofill on Desktop/IOS/Android. Is it expected?
PR #13077 is failing with KI #12777. There is also no option to zoom on mWeb. Can you double check its ok to checkoff? This one not working as expected

[luacmartins]

• Make the Switch to Dark Mode  #12944 (comment) yes, checking it off.
• Fix CSP console error when staging website is loaded #13054 Thanks! I pinged the author in the PR. I'll check it off now since it doesn't break any functionality
• Fix autofill styles #13119 yes, AFAIK only Web will have autofill enabled
• Fix/12777: Attachment -The image can be dragged by moving the cursor outside the image #13077 I pinged the authors. I'll come back to this one

[PauloGasparSv]

@luacmartins @mvtglobally

About #13077 I think there was no option to zoom on mWeb before so it's ok.
I tested sending a picture and pinching it on https://new.expensify.com/ and https://staging.new.expensify.com/ in my phone here and they are both working the same way.

Now I took a look at that build failure and I have no idea why it happened, the changes in that P.R. were very minimal. Re-running all failed jobs here to see if it works.

[PauloGasparSv]

Also, what do you mean by This one not working as expected @mvtglobally @luacmartins?

[mvtglobally]

@PauloGasparSv "This one not working as expected" I was referring to the zooming not properly working on mWeb and also to the issue #12777 still reproducing.

[aimane-chnaif]

@PauloGasparSv "This one not working as expected" I was referring to the zooming not properly working on mWeb and also to the issue #12777 still reproducing.

If that's the case, it doesn't cause any regression and I think it's fine to check it off.

[PauloGasparSv]

@mvtglobally Can you include video on #12777 of the issue still reproducing? I tested on my physical iOS device on the latest version of TestFlight and I cannot scroll outside of the image anymore.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-3 🚀

[PauloGasparSv]

Could not reproduce the deploy blocker #13141 so I asked for help on slack.

UPDATE: Could reproduce it but cannot think of a way of fixing it without reverting another P.R., asked for help on the GH itself.

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-3 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-4 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-4 has been deployed to staging 🎉

[mvtglobally]

#13142 is failing #13132

[luacmartins]

#13142 is failing #13132

@mvtglobally has the browser color not changed? This should be visible on the browser and desktop only. It's not visible on any of the mobile platforms.

[mvtglobally]

@luacmartins
Check this out

RPReplay_Final1669756796.MP4

[luacmartins]

@mvtglobally as I mentioned in my previous comment, the calendar icon is only displayed on Web and Desktop. The video is from mWeb. Is the calendar icon still not visible on Web?

[mvtglobally]

@luacmartins Is white routing number display expected for now?
I am double checking on calendar icon

[luacmartins]

Yes, that one is expected for now

[luacmartins]

We just merged PRs to fix #13141 and #13163. Should be available to test soon.

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-5 🚀

[luacmartins]

• Fix/12777: Attachment -The image can be dragged by moving the cursor outside the image #13077 I pinged the authors on the issue and asked them to investigate the failure. I'll check it off since it doesn't cause a regression.

[mvtglobally]

Calendar icon issue is resolved @luacmartins

[luacmartins]

Awesome, checking off #13142

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-5 has been deployed to staging 🎉

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-6 🚀

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-6 has been deployed to staging 🎉

[luacmartins]

#13164 is a pass. Checking off

Screen.Recording.2022-11-29.at.6.40.31.PM.mov

[OSBotify]

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.33-7 🚀

[luacmartins]

#13174 is a pass. Checking it off.

[luacmartins]

Checklist is clear. Starting the deploy!

[luacmartins]

[OSBotify]

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.33-7 has been deployed to staging 🎉