[HOLD for payment 2022-12-15] [HOLD for payment 2022-12-06] iOS - The dropdown menu text is very hard to see in date selector

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Access the New Expensify iOS app
2. Sign into a valid account
3. Click on Profile > Workspace > Connect bank > Connect manually
4. Enter routing information and proceed to the next page
5. Scroll down to the "Incorporation date" section and tap on the field, a drop down menu should open

Expected Result:

When the user taps the dropdown, all text should be clear and readable

Actual Result:

The dropdown menu text is very hard to see in date selector

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.2.34.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team / @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669787031782639

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[dhairyasenjaliya]

Proposal

Slack proposal link https://expensify.slack.com/archives/C049HHMV9SM/p1669787038687609?thread_ts=1669787031.782639&cid=C049HHMV9SM

• we just need to change themeVariant prop to dark in DatePicker index.ios.js

https://github.com/Expensify/App/blob/main/src/components/DatePicker/index.ios.js

          <RNDatePicker
            value={this.state.selectedDate}
            mode=“date”
            display=“spinner”
-            themeVariant=“light”
+            themeVariant=“dark” //for now once we get actual dark/light  variable we can set conditional based on selected theme
            onChange={this.updateLocalDate}
            locale={this.props.preferredLocale}
            maximumDate={this.props.maximumDate}
          />

[alex-mechler]

Snagging this one to knock it out super quick cc @JmillsExpensify

[dhairyasenjaliya]

@alex-mechler can you check my above proposal i add along with bug reporting #13203 (comment)

[alex-mechler]

Yup, that was also how I ended up solving it in the pr. I'll check to see if you are eligible for payment on that

[JmillsExpensify]

Thanks @alex-mechler!

[JmillsExpensify]

Also if we are using @dhairyasenjaliya's proposal in the internal PR, then I'm fine paying it out in this case.

[alex-mechler]

Yup, I used @dhairyasenjaliya's proposal, lets pay out like normal if #13210 solves the issue

[JmillsExpensify]

Noted, sounds great.

[JmillsExpensify]

Alright, let's swing back to the Upwork stuff since the PR is in review.

• Contributor: @dhairyasenjaliya $1,000
• Contributor+: @mananjadhav $1,000
• Issue reporter: @dhairyasenjaliya $250

Please apply to the Upwork job.

[dhairyasenjaliya]

applied @JmillsExpensify

[JmillsExpensify]

@mananjadhav Can you close the loop on the Upwork job offer? Once this hits production later today or tomorrow, we can issue payments and close the issue.

[JmillsExpensify]

All contributors paid out. I'm going to close this issue out for now, though I've created a thread on regression testing for dark mode. We'll need to make sure that this is included.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.36-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Use dark theme for ios DatePicker #13210

If no regressions arise, payment will be issued on 2022-12-15. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alex-mechler] The PR that introduced the bug has been identified. Link to the PR: [No QA] Core Branding: Add dark theme for internal testing #12478
• [@alex-mechler] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: [No QA] Core Branding: Add dark theme for internal testing #12478 (comment)
• [@alex-mechler] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: (discussion of the darkmode regressions) https://expensify.slack.com/archives/C01SKUP7QR0/p1670387206224449
• [@JmillsExpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[JmillsExpensify]

Nothing left to do here.