Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-12-01 #13240

Closed
11 tasks done
OSBotify opened this issue Dec 1, 2022 · 10 comments
Closed
11 tasks done

Deploy Checklist: New Expensify 2022-12-01 #13240

OSBotify opened this issue Dec 1, 2022 · 10 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Dec 1, 2022

Release Version: 1.2.35-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@luacmartins
Copy link
Contributor

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Dec 1, 2022
@OSBotify
Copy link
Contributor Author

OSBotify commented Dec 1, 2022

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.35-0 🚀

@luacmartins
Copy link
Contributor

@mvtglobally I see that we still have ~60% untested. Do you think we will have regression done by tomorrow morning?

@mvtglobally
Copy link

@luacmartins We will do our best. We are under 50% now
App has been really slow past 2 days which is impacting the regression timelines a lot.
https://expensify.slack.com/archives/C01GTK53T8Q/p1669929276346319

PR #13125 is failing #13252. it is repro in PROD,
PR #13184 is failing #12943, repro in PROD

@luacmartins
Copy link
Contributor

Thanks @mvtglobally!

@Julesssss
Copy link
Contributor

Checked off #13269 as the offending PR was reverted

@luacmartins
Copy link
Contributor

#13201 is already in prod. Checking it off

@mvtglobally
Copy link

@luacmartins Regression is completed

@luacmartins
Copy link
Contributor

Awesome! Kicking off the deploy!

@luacmartins
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants