-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the reviewer checklist from the PR template #13090
Conversation
@parasharrajat @MonilBhavsar One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@parasharrajat @MonilBhavsar you can disregard that previous ping and it's OK to merge this with the reviewer checklist failing since this doesn't touch any of the app code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Not sure why other unrelated tests are failing. Rerunning them...
I'm going to self merge this since @MonilBhavsar has approved it. The failing tests are known since having the author and reviewer checklists for this PR are not necessary. |
Triggered auto assignment to @johnmlee101 ( |
@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Validated that this worked here! |
🚀 Deployed to production by @luacmartins in version: 1.2.35-0 🚀
|
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/239867
Tests
None. Can only be tested once merged
Offline tests
None - this doesn't affect the app at all
QA Steps
PR Author Checklist
Checklist and screenshots do not apply since this is not a change to the app code