The outline around the buttons shows rectangle in shape when used Tab to focus

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open NewDot
2. Enter email address
3. Use Tab to focus on the Continue button

Expected Result:

Outline should be rounded at the ends

Actual Result:

Outline is rectangular

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.2.36-2

Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1670215788196829?thread_ts=1669646862.849829&cid=C049HHMV9SM

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c209fa348bb863c8
• Upwork Job ID: 1608159495458529280
• Last Price Increase: 2022-12-28

[melvin-bot]

Triggered auto assignment to @davidcardoza (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[marcaaron]

@shawnborton let me know if something like this would work for you...

2022-12-06_10-30-57.mp4

I'm thinking that another direction we could possibly take this in is to:

• Disable the default outline (like we did with the text input)
• Use the same light green color for focusing buttons

[shawnborton]

I like the blue so it is differentiated from the button color, and yeah, what you have there looks great in terms of shape!

[melvin-bot]

@marcaaron Eep! 4 days overdue now. Issues have feelings too...

[marcaaron]

Have to test this on a few more platforms, but should be in review soon.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@marcaaron Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@marcaaron 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c209fa348bb863c8

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the Internal assigner, not assigning anyone new.

[mallenexpensify]

@aimane-chnaif can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01c209fa348bb863c8

[aimane-chnaif]

@mallenexpensify accepted. thanks

[mallenexpensify]

Paid @aimane-chnaif
@marcaaron this needs regression test steps added, right?
Assuming so, I'll assign myself to tackle

[melvin-bot]

@mallenexpensify, @marcaaron, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mallenexpensify]

Regression test steps posted in #bug-zero
https://expensify.slack.com/archives/C01SKUP7QR0/p1672870590865169

[melvin-bot]

@mallenexpensify, @marcaaron, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mallenexpensify]

@marcaaron @aimane-chnaif are the top three below needed for this? I got #4

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• The PR that introduced the bug has been identified. Link to the PR:
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/254826

[trjExpensify]

👋 Just to confirm. This is the only PR needed for this issue and it has been deployed, right? If so, let's add the reviewing label so it doesn't appear like it's still without one (and as a result breaking WAQ come Monday). Thanks!

[marcaaron]

I don't think it was a regression @mallenexpensify so no. It was on production when reported so none of those steps are necessary AFAICT. Unless I have missed something..

[marcaaron]

@trjExpensify Re-adding the reviewing label.

[trjExpensify]

Thank yah

[marcaaron]

Actually I mean it's on production right so it should be closed? I'm lost on why this is still open.

[marcaaron]

Maybe we haven't paid @aimane-chnaif - been 3 weeks though 😬

[trjExpensify]

Presumably for the checklist? Regression test issue was created today, for example.

[aimane-chnaif]

Maybe we haven't paid @aimane-chnaif - been 3 weeks though 😬

I got payment. Thanks for reminder.
Feel free to close if BugZero Checklists are complete.

[mallenexpensify]

Closing!