Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving files and folders a little #4

Merged
merged 4 commits into from
Aug 8, 2020
Merged

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Aug 8, 2020

No description provided.

@tgolen tgolen requested a review from AndrewGable August 8, 2020 15:53
@tgolen tgolen self-assigned this Aug 8, 2020
@AndrewGable
Copy link
Contributor

I saw this error when running on iOS:

jest-haste-map: Watchman crawl failed. Retrying once with node crawler.
  Usually this happens when watchman isn't running. Create an empty `.watchmanconfig` file in your project's root folder or initialize a git or hg repository in your project.
  Error: Watchman error: resolve_projpath: path `./src`: open: ./src: No such file or directory. Make sure watchman is running for this project. See https://facebook.github.io/watchman/docs/troubleshooting.html.
Error: Expected file to be absolute path but got ./src/.
    at new Module (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/node-haste/Module.js:17:13)
    at ModuleCache.getModule (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/node-haste/ModuleCache.js:26:37)
    at DependencyGraph.resolveDependency (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/node-haste/DependencyGraph.js:287:52)
    at /Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/lib/transformHelpers.js:267:42
    at Server.<anonymous> (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/Server.js:841:41)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/Server.js:99:24)
    at _next (/Users/andrew/Expensidev/ReactNativeChat/node_modules/metro/src/Server.js:119:9)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

metro.config.js Outdated
},
}),
},
projectRoot: './src',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this line and it will actually work just fine

@tgolen
Copy link
Contributor Author

tgolen commented Aug 8, 2020

Updated to remove the projectRoot option

@AndrewGable AndrewGable merged commit 7779fa9 into master Aug 8, 2020
@AndrewGable AndrewGable deleted the tgolen-async-promise branch August 8, 2020 16:21
marcaaron pushed a commit that referenced this pull request Feb 22, 2021
AndrewGable pushed a commit that referenced this pull request Mar 4, 2021
Julesssss pushed a commit that referenced this pull request Apr 7, 2021
@OSBotify
Copy link
Contributor

🚀 [Deployed](https://github.com/Expensify/Expensify.cash
/actions/runs/765130740) 🚀 to
staging on Mon Apr 19 2021 at 22:41:56 GMT+0000 (Coordinated Universal Time)

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

stitesExpensify pushed a commit that referenced this pull request Oct 28, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @AndrewGable in version: 1.1.10-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.11-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1bfd5f1
Status: ✅  Deploy successful!
Preview URL: https://6efe25f5.helpdot.pages.dev

View logs

Copy link

melvin-bot bot commented Nov 26, 2024

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

Copy link

melvin-bot bot commented Nov 26, 2024

Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants