[$500] IOS - The Chat report displays the wrong Latest Sender's name in LHN after logging in

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

PRECONDITION: The user has joined a public group chat with a long chat history. For Example:

- Bob-testing: https://staging.new.expensify.com/r/5593084223054221

1. Log in to the account that has joined a public/group chat with a long chat history.
2. On the LHN: check the name of the Latest Sender displayed.
3. Open the chat to view chat's details.
4. Verify the actual sender who sent the Last Message in the chat.
5. Compare the Sender's name from step Moving files and folders a little #4 with the name obtained in step Fix spaces #2.
6. Observe that the latest sender's name is different.

Expected Result:

The latest sender's name should match between step #4 and #2

Actual Result:

The latest sender's name is different.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.62.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Wrong-Latest-Sender.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1693213921747209

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01bd85da703f1b3f23
• Upwork Job ID: 1699155042104852480
• Last Price Increase: 2023-09-26

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[slafortune]

Applying the external label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01bd85da703f1b3f23

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ArekChr (External)

[slafortune]

Still waiting on proposals.

Assigning a new BZ member, I am out on sabbatical

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[isabelastisser]

Not overdue; waiting on proposals!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[isabelastisser]

Still waiting for proposals!

[isabelastisser]

Still waiting for proposals.

[isabelastisser]

hey @barttom, any updates?

[barttom]

I agree with the proposal from @MrMuzyk. Looks like we waiting for reviewing proposal by @aimane-chnaif.

[aimane-chnaif]

I tested and reproduced with #bobs-testing. It says "No activity yet" before opening report

Screen.Recording.2023-10-31.at.8.16.24.AM.mov

[aimane-chnaif]

It's super weird that last message sender name is concierge@expensify.com before opening report

Screen.Recording.2023-10-31.at.8.29.13.AM.mov

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Issue 1. Wrong sender name (from whisper message) shows in LHN before opening report after visit that report, logout and re-login
Issue 2. "No activity yet" shows after refresh

What is the root cause of that problem?

Issue 1. wrong sender name (from whisper message)
Whispered messages are not filtered here:

App/src/libs/SidebarUtils.ts

Lines 38 to 44 in deb267f

	const reportActionsForDisplay = actionsArray.filter(
	(reportAction, actionKey) =>
	ReportActionsUtils.shouldReportActionBeVisible(reportAction, actionKey) &&
	reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED &&
	reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
	);
	visibleReportActionItems[reportID] = reportActionsForDisplay[reportActionsForDisplay.length - 1];

So lastActorDisplayName is set to sender name of whisper message here:

App/src/libs/SidebarUtils.ts

Line 407 in deb267f

const lastActorDisplayName = visibleReportActionItems[report.reportID]?.person?.[0]?.text;

Issue 2. "No activity yet" after refresh

App/src/libs/SidebarUtils.ts

Lines 459 to 463 in deb267f

	} else if (lastAction?.actionName !== CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW && lastActorDisplayName && lastMessageTextFromReport) {
	result.alternateText = `${lastActorDisplayName}: ${lastMessageText}`;
	} else {
	result.alternateText = lastAction && lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');
	}

lastActorDisplayName and lastAction don't exist so fallback to Localize.translate(preferredLocale, 'report.noActivityYet')

Summary:
When visit the report, visibleReportActionItems are set globally here:

App/src/libs/SidebarUtils.ts

Line 22 in deb267f

const visibleReportActionItems: ReportActions = {};

But after logout, this data is not cleared so remains as stale value.
After re-login, app is still using stale data and that's why Issue 1. happens.
After refresh, all stale data is cleared so whisper message no longer exists until open that report again. That's why Issue 1 changes to Issue 2.

What changes do you think we should make in order to solve the problem?

Solution to Issue 1:
add !ReportActionsUtils.isWhisperAction(reportAction) && to filter condition

Solution to Issue 2:
Remove lastAction && condition here:

App/src/libs/SidebarUtils.ts

Line 462 in deb267f

result.alternateText = lastAction && lastMessageTextFromReport.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');

As a result, it shows {lastMessageText} without {sender name}: prefix if sender name doesn't exist.
So it's better than No activity yet

What alternative solutions did you explore? (Optional)

As others proposed, add new field lastActorDisplayName to report object, along with lastMessageText.
But this is new feature request and I don't think we wanna do that right now.

[aimane-chnaif]

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[aimane-chnaif]

@thienlnam thanks for taking this issue. There are 2 possible solutions to fix this issue

Issue: report object doesn't contain sender's display name so no way to display if sender is not in personal details list

Solution 1: introduce new key (something like report.lastActorDisplayName) (proposal)
Solution 2: hide sender name in last message, like DM (proposal)

Which solution do you suggest?

[thienlnam]

Ah interesting, so you might not have the personal details of the last actor accountID and so it just falls back to the most recent visible action?

If we added the key lastActorDisplayName, that would essentially be the fallback if don't have that accountID in your personal details right because otherwise it would pull the actual display name or email.

I don't really like the idea of adding another key to determine which name to show considering it's only applicable for certain users, and then there's always the question of which display name to use - from the lastReportAction or the report and keeping those in sync we'd probably have to make a decent amount of onyx optimistic updates

I'm leaning towards the second solution since that seems to be how we handle these other scenarios where we don't have personal details for a user.

Though curious if ya'll agree (@puneetlath / @Beamanator)

[puneetlath]

Ah interesting. So we get the personalDetails in the openReport command, but since that hasn't been called yet it can be wrong. I agree with just not showing a display name in the case where we don't have it.

[aimane-chnaif]

Ah interesting. So we get the personalDetails in the openReport command, but since that hasn't been called yet it can be wrong. I agree with just not showing a display name in the case where we don't have it.

Thanks for the feedback

Let's go with @mkhutornyi's proposal
cc: @thienlnam

[aimane-chnaif]

@puneetlath one more thing to confirm:

when sender name is in the middle, what to show? Maybe something like [Hidden] or leave empty as is?

Screen.Recording.2023-11-01.at.8.00.24.PM.mov

EDIT:

I noticed it's not possible to customize. It's something to be fixed in backend.

[puneetlath]

Yeah, we'll need to handle that on the back-end.

[aimane-chnaif]

This is ready for payment. @isabelastisser can you please update to Daily?

[isabelastisser]

Payment summary:

Issue reported by: @tranvantoan-qn $50
C+ review: @aimane-chnaif $500
Accepted proposal: @mkhutornyi $500

[isabelastisser]

Offers sent in Upwork. All set!

[tranvantoan-qn]

@isabelastisser
I've accepted the offer. But shouldn't we process the payment first before closing it?