Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev - mWeb - App crashes on sign in #13473

Closed
kavimuru opened this issue Dec 9, 2022 · 4 comments · Fixed by #13482
Closed

Dev - mWeb - App crashes on sign in #13473

kavimuru opened this issue Dec 9, 2022 · 4 comments · Fixed by #13482
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Dec 9, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open ND
  2. Sign in

Expected Result:

User successfully signed in

Actual Result:

App crashes

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: Needs reproduction
Reproducible in staging?: Occurring in Dev
Reproducible in production?: Occurring in Dev
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
safari_crash.txt
Untitled.txt

Notes/Photos/Videos:
Screenshot 2022-12-09 at 10 59 01 AM

Expensify/Expensify Issue URL:
Issue reported by: @marcaaron
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1670528976295469

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 9, 2022

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Dec 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 9, 2022

Triggered auto assignment to @MonilBhavsar (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@dangrous
Copy link
Contributor

dangrous commented Dec 9, 2022

Just hopping in to note that this same crash happens to me on desktop web as well - null is not an object (evaluating 'this.dropZone.getBoundingClientRect') showing up in the console there, with some pointing to the DragAndDrop component

@francoisl
Copy link
Contributor

Fixed with this revert - no need to wait on a deploy since the offending PR wasn't deployed to staging yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment Engineering Reviewing Has a PR in review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants