Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] iouAmountText not aligned with currency text #13471

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[Fix] iouAmountText not aligned with currency text #13471

merged 1 commit into from
Dec 13, 2022

Conversation

fedirjh
Copy link
Contributor

@fedirjh fedirjh commented Dec 9, 2022

Details

Fixed edge cases where amount digit in send money page is not aligned with currency text

Fixed Issues

$ #13309
#13309 (comment)

Tests / Offline tests / QA Steps

  1. Open app
  2. Click on + icon (green) > split bill or request money
  3. Enter any digit
  4. Amount digit is aligned with currency text
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Safari

Screenshot 2022-12-09 at 3 21 34 PM

Chrome

Screenshot 2022-12-09 at 3 23 44 PM
Mobile Web - Chrome

Screenshot_1670597198

Mobile Web - Safari

Simulator Screen Shot - iPhone 13 - 2022-12-09 at 15 31 29

Screenshot 2022-12-09 at 3 32 02 PM
Desktop Screenshot 2022-12-09 at 3 25 29 PM
iOS

Simulator Screen Shot - iPhone 13 - 2022-12-09 at 15 17 10

Android

Screenshot_1670596799

@fedirjh fedirjh requested a review from a team as a code owner December 9, 2022 14:47
@melvin-bot melvin-bot bot requested review from PauloGasparSv and rushatgabhane and removed request for a team December 9, 2022 14:48
@melvin-bot
Copy link

melvin-bot bot commented Dec 9, 2022

@PauloGasparSv @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@fedirjh fedirjh mentioned this pull request Dec 9, 2022
Closed
@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Dec 9, 2022 •
edited
Loading

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web Web
Mobile Web - Chrome mweb android
Mobile Web - Safari web Ios
Desktop Desktop
iOS ios
Android Android

@PauloGasparSv
Copy link
Contributor

PauloGasparSv commented Dec 9, 2022 •
edited
Loading

Cannot test the Mobile iOS or Android versions here, having the following crash that is being discussed in slack here. (Update: GH created for this issue)

Error

image

[Error] TypeError: null is not an object (evaluating 'this.dropZone.getBoundingClientRect')
	(anonymous function) (react-dom.development.js:115)
	callCallback (react-dom.development.js:4161)
	dispatchEvent
	invokeGuardedCallbackDev (react-dom.development.js:4210)
	invokeGuardedCallback (react-dom.development.js:4274)
	reportUncaughtErrorInDEV (react-dom.development.js:22732)
	captureCommitPhaseError (react-dom.development.js:27073)
	commitLayoutMountEffects_complete (react-dom.development.js:24575)
	commitLayoutEffects_begin (react-dom.development.js:24559)
	commitLayoutEffects (react-dom.development.js:24497)
	commitRootImpl (react-dom.development.js:26774)
	commitRoot (react-dom.development.js:26633)
	performSyncWorkOnRoot (react-dom.development.js:26068)
	performSyncWorkOnRoot
	flushSyncCallbacks (react-dom.development.js:12009)
	flushSyncCallbacksOnlyInLegacyMode (react-dom.development.js:11988)
	scheduleUpdateOnFiber (react-dom.development.js:25433)
	enqueueSetState (react-dom.development.js:13264)
	(anonymous function) (react.development.js:353)
	setWithOnyxState (web.development.js:2534)
	setWithOnyxState
	sendDataToConnection (web.development.js:1078)
	(anonymous function) (web.development.js:1212)
	promiseReactionJob
[Error] WebSocket connection to 'wss://ws-mt1.pusher.com/app/ac6d22b891daae55283a?protocol=7&client=js&version=7.4.0&flash=false' failed: WebSocket is closed before the connection is established.
	(anonymous function) (pusher-with-encryption.js:4056)
	abort (pusher-with-encryption.js:6668)
	abort (pusher-with-encryption.js:5608)
	abort (pusher-with-encryption.js:5575)
	abortRunner (pusher-with-encryption.js:5671)
	apply (pusher-with-encryption.js:3507)
	abort (pusher-with-encryption.js:5655)
	abort (pusher-with-encryption.js:5731)
	(anonymous function) (pusher-with-encryption.js:5233)
	(anonymous function) (pusher-with-encryption.js:5238)
	(anonymous function) (pusher-with-encryption.js:5203)
	(anonymous function) (pusher-with-encryption.js:7220)
	disconnect (pusher.js:378)
	cleanupSession (index.js:410)
	componentWillUnmount (AuthScreens.js:190)
	callComponentWillUnmountWithTimer (react-dom.development.js:22751)
	safelyCallComponentWillUnmount (react-dom.development.js:22767)
	commitDeletionEffectsOnFiber (react-dom.development.js:24022)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24026)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24026)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24026)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24063)
	recursivelyTraverseDeletionEffects (react-dom.development.js:23882)
	commitDeletionEffectsOnFiber (react-dom.development.js:24011)
	commitDeletionEffects (react-dom.development.js:23869)
	recursivelyTraverseMutationEffects (react-dom.development.js:24152)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24239)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24461)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24225)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24239)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24239)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
	commitMutationEffectsOnFiber (react-dom.development.js:24186)
	recursivelyTraverseMutationEffects (react-dom.development.js:24166)
[Error] The above error occurred in the <DragAndDrop> component:

_classCallCheck@
div
View
_classCallCheck@
withLocalize(AttachmentModal)
withWindowDimensions(withLocalize(AttachmentModal))
div
View
div
View
_classCallCheck@
_classCallCheck@
WithCurrentUserPersonalDetails(Component)
_classCallCheck@
withPersonalDetails(Component)
withNetwork(withPersonalDetails(Component))
withLocalize(withNetwork(withPersonalDetails(Component)))
withNavigationFocus(withLocalize(withNetwork(withPersonalDetails(Component))))
withDrawerState(Component)
withWindowDimensions(Component)
div
View
div
View
OfflineWithFeedback
withNetwork(OfflineWithFeedback)
withLocalize(withNetwork(OfflineWithFeedback))
__WEBPACK_DEFAULT_EXPORT__
div
View
_classCallCheck@
_classCallCheck@
withWindowDimensions(Component)
div
View
Suspense
Freeze
div
View
KeyboardAvoidingView
div
View
_classCallCheck@
withNetwork(ScreenWrapper)
_classCallCheck@
withWindowDimensions(Component)
withNavigation(withWindowDimensions(Component))
_classCallCheck@
_classCallCheck@
withNetwork(Component)
withDrawerState(withNetwork(Component))
withWindowDimensions(Component)
withLocalize(withWindowDimensions(Component))
StaticContainer
EnsureSingleNavigator
SceneView
div
View
div
View
Background
Screen
div
View
Component@
_classCallCheck@
AnimatedComponentWrapper
MaybeScreen
div
View
MaybeScreenContainer
div
View
div
View
_classCallCheck@
div
View
_classCallCheck@
_classCallCheck@
GestureDetector
Drawer
DrawerViewBase
div
View
div
View
SafeAreaProviderCompat
DrawerView
PreventRemoveProvider
NavigationContent
DrawerNavigator
_classCallCheck@
withWindowDimensions(BaseDrawerNavigator)
_classCallCheck@
_classCallCheck@
StaticContainer
EnsureSingleNavigator
SceneView
div
View
div
View
div
View
CardSheet
div
View
_classCallCheck@
AnimatedComponentWrapper
Dummy
div
View
_classCallCheck@
AnimatedComponentWrapper
div
View
Component@
CardContainer
div
View
Component@
_classCallCheck@
AnimatedComponentWrapper
MaybeScreen
div
View
MaybeScreenContainer
div
View
Background
Component@
div
View
SafeAreaProviderCompat
div
View
Component@
CustomRootStackNavigator
_classCallCheck@
_classCallCheck@
withWindowDimensions(Component)
AppNavigator
EnsureSingleNavigator
BaseNavigationContainer
ThemeProvider
NavigationContainerInner
NavigationRoot
_classCallCheck@
_classCallCheck@
withLocalize(Component)
_classCallCheck@
_classCallCheck@
RenderersPropsProvider
ListStyleSpecsProvider
SharedPropsProvider
RenderRegistryProvider
RenderHTMLConfigProvider
TRenderEngineProvider
BaseHTMLEngineProvider
HTMLEngineProvider
withWindowDimensions(HTMLEngineProvider)
_classCallCheck@
_classCallCheck@
withOnyx(LocaleContextProvider)
__WEBPACK_DEFAULT_EXPORT__
PortalProviderComponent
div
View
NativeSafeAreaProvider
SafeAreaProvider
BetasProvider
_classCallCheck@
Private_blockedFromConciergeProvider
_classCallCheck@
CurrentDateProvider
_classCallCheck@
ReportActionsDrafts_Provider
_classCallCheck@
PersonalDetailsProvider
_classCallCheck@
NetworkProvider
_classCallCheck@
ComposeProviders
OnyxProvider
ComposeProviders
div
View
GestureHandlerRootView
App
div
View
div
View
AppContainer

React will try to recreate this component tree from scratch using the error boundary you provided, BaseErrorBoundary.
	logCapturedError (react-dom.development.js:18572)
	callback (react-dom.development.js:18635)
	callCallback (react-dom.development.js:13122)
	commitUpdateQueue (react-dom.development.js:13143)
	commitLayoutEffectOnFiber (react-dom.development.js:23258)
	commitLayoutMountEffects_complete (react-dom.development.js:24573)
	commitLayoutEffects_begin (react-dom.development.js:24559)
	commitLayoutEffects (react-dom.development.js:24497)
	commitRootImpl (react-dom.development.js:26774)
	commitRoot (react-dom.development.js:26633)
	performSyncWorkOnRoot (react-dom.development.js:26068)
	performSyncWorkOnRoot
	flushSyncCallbacks (react-dom.development.js:12009)
	flushSyncCallbacksOnlyInLegacyMode (react-dom.development.js:11988)
	scheduleUpdateOnFiber (react-dom.development.js:25433)
	enqueueSetState (react-dom.development.js:13264)
	(anonymous function) (react.development.js:353)
	setWithOnyxState (web.development.js:2534)
	setWithOnyxState
	sendDataToConnection (web.development.js:1078)
	(anonymous function) (web.development.js:1212)
	promiseReactionJob

PauloGasparSv
PauloGasparSv approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@PauloGasparSv PauloGasparSv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approving, once mobile web is back we can add the remaining evidences and merge

@PauloGasparSv
Copy link
Contributor

Added the remaining evidence :D
Had to pull from origin main to test since mweb was fixed yesterday. All yours @rushatgabhane

@PauloGasparSv
Copy link
Contributor

@rushatgabhane Merging this!

@PauloGasparSv PauloGasparSv merged commit 77794ba into Expensify:main Dec 13, 2022
@chiragsalian chiragsalian mentioned this pull request Dec 14, 2022
Closed
13 tasks
@fedirjh fedirjh deleted the Fix-13309 branch December 15, 2022 14:09
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.2.39-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PauloGasparSv PauloGasparSv PauloGasparSv approved these changes

@rushatgabhane rushatgabhane Awaiting requested review from rushatgabhane

Assignees

@fedirjh fedirjh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedirjh @PauloGasparSv @OSBotify