-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-01-30] [$1000] New Room - Capital letters is converted to lowercase when all caps is enable #13676
Comments
Triggered auto assignment to @Christinadobrzyn ( |
This might be related - #13463 @sketchydroide can I get your thoughts if this is the same issue (I see the PR merged so maybe it's not)? It might also be related to this - #13042 - maybe capital letters are considered a special character right now? @madmax330 can I get your thoughts? |
It's not related, but I'm not sure if we can do something about it, this is mobile iOS and Android, the other one was Android only. Either way @Christinadobrzyn I think this GH will be closed. |
Thanks @sketchydroide! We'll wait to hear from @madmax330 to see if he might have more info on this issue being resolved with #13042 |
I'm ooo so going to reassign |
Also waiting for feedback from @madmax330 |
@madmax330 should be back from OOO today |
I don't think my fix for the other issue will fix this. |
is there a method for that? Atm we are using |
I think onChange should be fine. It's just that we should make sure the correct value is set before rendering it |
@madmax330 @sketchydroide , what's best next step here? |
Assigning @madmax330 and @sketchydroide cuz otherwise they might not see. Can you review the above and provide guidance? plzzzz |
Thanks @sketchydroide, applied on Upwork. @thesahindia Can you plz let me know from where I can confirm translation ? |
I'm using Spanish: Los nombres de las habitaciones solo pueden incluir letras minúsculas, números y guiones Need confirmation |
I'll get that done for you, we normally ask in an internal slack channel where the native Spanish speakers can chime in. |
I would say |
Ok @sketchydroide waiting for your confirmation, I have converted English to Spanish with google translate may be its incorrect. Plz also confirm English string I have picked it from #13676 (comment)
|
No worries, yeah, the translation from Google is not completly incorrect, it's one of those context changes translations things |
ok got a confirmation to |
Ok @sketchydroide English string suggested here #13676 (comment) I'm going to add these. will submit PR within 1 hour |
This comment was marked as outdated.
This comment was marked as outdated.
PR is ready for review cc @thesahindia |
Hired @jatinsonijs, thanks for the quick PR. |
Accepted! |
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.57-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-01-30. 🎊 After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
We can leave the first 3 checkboxes since it wasn't a regression. It was implemented this way. |
@mallenexpensify, this is ready for payment. |
@jatinsonijs assigned on Jan 18 Paid @jatinsonijs and @thesahindia $1500 each which includes the timeliness bonus. Posted buddy check for regression test steps |
No action is needed from me so unassigning. P.S. The steps looks good to me |
Testrail GH created https://github.com/Expensify/Expensify/issues/260050 @thesahindia @sketchydroide @madmax330 can you review and take action on the top 3 in the checklist plz, then we can close #13676 (comment) |
As mentioned in #13676 (comment). I think we can leave those because it wasn't a regression. |
K, I checked them off then. @thesahindia are C+ able to check off boxes? Can't remember |
Nope, we can't edit. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #13621
Action Performed:
Expected Result:
Capital letters is visible until an area outside of the field is tapped.
Capital letters is not visible and transaction is smooth when all caps is enabledActual Result:
Capital letter changes to lowercase.
Capital letters is visible and transaction isn't smooth when all caps is enableWorkaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.2.41.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5866671_Screen_Recording_20221216-122119_New_Expensify__1_.mp4
Bug5866671_RPReplay_Final1671212576.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: