Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-02-03] Multiple Podfiles warning #13749

Closed
1 task done
roryabraham opened this issue Dec 21, 2022 · 5 comments
Closed
1 task done

[HOLD for payment 2023-02-03] Multiple Podfiles warning #13749

roryabraham opened this issue Dec 21, 2022 · 5 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Task Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Run cd ios && pod install

Expected Result:

There should be no warnings.

Actual Result:

This warning appears:

warn Multiple Podfiles were found: ios/Podfile,vendor/bundle/ruby/2.7.0/gems/cocoapods-core-1.11.3/lib/cocoapods-core/Podfile. Choosing ios/Podfile automatically. If you would like to select a different one, you can configure it via "project.ios.sourceDir". You can learn more about it here: https://github.com/react-native-community/cli/blob/master/docs/configuration.md

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • iOS / native

View all open jobs on GitHub

@roryabraham roryabraham self-assigned this Dec 21, 2022
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Dec 21, 2022
@roryabraham
Copy link
Contributor Author

We can easily fix this by just adding sourceDir: 'ios' into the object right here

@melvin-bot melvin-bot bot added the Overdue label Jan 23, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels Jan 25, 2023
@roryabraham
Copy link
Contributor Author

Got a PR up and ready for review.

@roryabraham
Copy link
Contributor Author

This was fixed by #14541, no payment due

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 labels Jan 27, 2023
@melvin-bot melvin-bot bot changed the title Multiple Podfiles warning [HOLD for payment 2023-02-03] Multiple Podfiles warning Jan 27, 2023
@melvin-bot melvin-bot bot unlocked this conversation Jan 27, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 27, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jan 27, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.60-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-02-03. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

1 participant