[No QA] Fix pod install warning

[roryabraham]

Details

This just fixes a pod install warning.

Fixed Issues

$ #13749

Tests

1. Run cd ios && pod install && cd ..
2. Verify that the warning is gone.

• Verify that no errors appear in the JS console

Offline tests

None

QA Steps

None.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Before	After

[melvin-bot]

@mollfpr @amyevans One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[roryabraham]

Removing C+ review because it shouldn't be needed here.

[amyevans]

❤️ Thanks for fixing, that warning has been annoying me 😄

[amyevans]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	687.810 ms → 697.370 ms (+9.560 ms, +1.4%)
App start runJsBundle	194.844 ms → 195.906 ms (+1.063 ms, +0.5%)
App start regularAppStart	0.015 ms → 0.015 ms (+0.000 ms, +2.7%)
App start nativeLaunch	19.281 ms → 18.900 ms (-0.381 ms, -2.0%)
Open Search Page TTI	606.014 ms → 600.581 ms (-5.433 ms, -0.9%)

Show details

Name	Duration
App start TTI	Baseline Mean: 687.810 ms Stdev: 29.969 ms (4.4%) Runs: 628.6515350006521 645.0979699995369 645.2809350006282 650.3349380008876 653.7019389998168 657.2717259991914 658.3826299998909 667.9572429992259 669.2448849994689 669.3515050001442 672.7834370005876 677.4660640005022 679.3254550006241 680.6985199991614 680.8166579995304 683.2709810007364 689.0776899997145 689.4073539990932 690.8163339998573 694.5791689995676 696.8508730009198 706.7422100007534 708.0491269994527 714.034552000463 716.2954999990761 724.6746430005878 727.127111999318 730.5304550006986 735.1204940006137 738.4848769996315 740.6770869996399 Current Mean: 697.370 ms Stdev: 22.616 ms (3.2%) Runs: 656.9692090004683 657.3747010007501 661.0666690003127 666.5338979996741 671.8626789990813 673.3506819996983 674.8442030008882 674.8895689994097 688.027983000502 688.3613920006901 693.1308549996465 694.9508170001209 696.6953469999135 699.2305079996586 700.5129489991814 702.6954219993204 702.8123540002853 702.956778999418 703.4620329998434 705.659789999947 707.2680859994143 707.2759300004691 709.707776999101 712.0999820008874 713.8800290003419 715.7210029996932 721.7728000003844 732.0715820007026 736.9629219993949 748.9530650004745
App start runJsBundle	Baseline Mean: 194.844 ms Stdev: 22.040 ms (11.3%) Runs: 160 164 166 169 171 173 174 177 178 181 182 182 182 189 192 192 193 194 197 199 199 202 203 205 215 216 221 222 226 230 232 249 Current Mean: 195.906 ms Stdev: 18.137 ms (9.3%) Runs: 172 173 175 175 176 176 177 179 180 183 186 186 186 188 188 190 190 197 200 201 203 203 204 204 209 217 218 221 223 224 232 233
App start regularAppStart	Baseline Mean: 0.015 ms Stdev: 0.001 ms (9.0%) Runs: 0.012897999957203865 0.013141999021172523 0.013345999643206596 0.01342799887061119 0.01342800073325634 0.013467999175190926 0.013508999720215797 0.013509001582860947 0.013549000024795532 0.013671999797224998 0.01371300034224987 0.013875000178813934 0.014038000255823135 0.014039000496268272 0.01411999948322773 0.014242000877857208 0.014485999941825867 0.01452699862420559 0.014566998928785324 0.014649000018835068 0.014729999005794525 0.014730000868439674 0.01505499891936779 0.015056001022458076 0.015258999541401863 0.01550300046801567 0.016114000231027603 0.016927000135183334 0.017455998808145523 0.017578000202775 0.017660001292824745 Current Mean: 0.015 ms Stdev: 0.001 ms (6.7%) Runs: 0.013263998553156853 0.013590000569820404 0.013915998861193657 0.014037998393177986 0.014038000255823135 0.014159999787807465 0.014363998547196388 0.014363998547196388 0.014364000409841537 0.014404000714421272 0.01448499970138073 0.014526000246405602 0.014526000246405602 0.014567000791430473 0.01464799977838993 0.01469000056385994 0.014729000627994537 0.014932999387383461 0.01493300125002861 0.014973999932408333 0.015298999845981598 0.015298999845981598 0.01534000039100647 0.015543000772595406 0.015869000926613808 0.015951000154018402 0.016112999990582466 0.01619499921798706 0.016439000144600868 0.016600999981164932 0.018188999965786934
App start nativeLaunch	Baseline Mean: 19.281 ms Stdev: 1.700 ms (8.8%) Runs: 17 17 17 17 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 20 20 20 20 20 21 21 21 21 22 23 24 Current Mean: 18.900 ms Stdev: 1.422 ms (7.5%) Runs: 17 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 18 19 19 19 19 20 20 20 21 21 21 22 23
Open Search Page TTI	Baseline Mean: 606.014 ms Stdev: 22.212 ms (3.7%) Runs: 553.2271330002695 572.1603599991649 584.168293999508 585.4345300011337 586.8855390008539 587.5078940000385 588.8247480001301 588.9621590003371 593.9862879998982 594.0954180005938 594.8952230010182 597.6327720005065 599.0727940015495 600.590616999194 602.5549320001155 604.2880049999803 605.4551189988852 605.6212569996715 606.933960000053 607.4562590010464 610.5551359988749 610.7917080000043 612.7163079995662 613.574706999585 614.2615970000625 625.231974998489 625.5887049995363 629.8684080000967 634.5064700003713 640.0650230012834 647.2361660003662 668.2833659984171 Current Mean: 600.581 ms Stdev: 8.971 ms (1.5%) Runs: 585.6153970006853 585.6302499994636 585.7746580000967 588.5460209995508 589.0004879999906 590.4173179995269 592.9137779995799 593.7390139997005 594.4791270010173 595.8699140008539 596.859985999763 598.1188960000873 598.2274169996381 598.4822189994156 598.6577959991992 602.4161789994687 603.0969650000334 603.5096850004047 605.7212320007384 606.581706000492 607.4855960011482 607.8169350009412 607.8824870008975 608.1785480007529 608.2084969989955 608.4463309999555 610.6846520006657 610.7356770001352 616.9547530002892 617.3668210003525

[OSBotify]

🚀 Deployed to staging by https://github.com/amyevans in version: 1.2.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.60-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅