[HOLD for payment 2023-01-25] [$1000] Long text strings disappear from single-line text fields when text is too long

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action performed:

1. Login with any account
2. Choose any single line TextInput, ie: First name, Last name, Workspace name.
3. Enter the long text with multiple words, for example: Visaocuoitroi193's Workspacethisverylongtext and save entry

Expect result:

If the full text is too long to fit in the text field, the text should be cut off and we should add a ... to show that the string continues.

Actual result:

Any words that go past the end of the text field disappear from view. (I think it's because they are moved to a newline)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• iOS / native

Version Number: 1.2.43-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

RPReplay_Final1671544761.MP4

HVLF3370.1.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671552728713329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01174c064be0dcafb8
• Upwork Job ID: 1611117990550892544
• Last Price Increase: 2023-01-05

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[sakluger]

This doesn't have anything to do with the ' actually. What's happening is that if you add a long string of characters after a space, the word moves down to the next line (basically text wrapping).

I posted in the original Slack thread to see if we'd like to fix and what the expected behavior should be in this case.

[sakluger]

Changing this to weekly and we will revisit in the new year when more people are back online.

[sakluger]

We discussed in Slack and decided that we should fix this and that it should be external. Adding the label now.

[sakluger]

FYI, I updated the title and issue description to be a bit more accurate to what the issue is.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01174c064be0dcafb8

[melvin-bot]

Current assignee @sakluger is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.55-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix long text cut in iOS single line input #14273

If no regressions arise, payment will be issued on 2023-01-25. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @yuwenmemon] The PR that introduced the bug has been identified. Link to the PR: Fix: App changes positions of Ui elements when phone language RTL #7594
• [@mollfpr / @yuwenmemon] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix: App changes positions of Ui elements when phone language RTL #7594 (comment)
• [@mollfpr / @yuwenmemon] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. No discussion needed
• [@sakluger] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

[sakluger]

I've sent offers to @hungvu193 (issue reporter), @mollfpr (contributor+), and @0xmiroslav (contributor) on the Upwork job, please accept the offer when you have a chance! Since the PR was merged quickly, it is eligible for the efficiency bonus as long as there are no regressions.

I'm discussing adding regression test steps here in Slack. It's a little tricky because the behavior is different depending on the platform (iphone vs android vs web). I'll update once we've made a decision there.

[mollfpr]

@sakluger Thanks, accepted!

[sakluger]

Hey everyone, sorry I did not notice this sooner, but as mentioned in my last comment, I noticed that the behavior is different for different platforms:

• On the iPhone app, we add a ... to the end of single line text fields if the text is too long

• On the Desktop App and web, there is no ..., it just cuts off the text at the end of the field and I can scroll left and right

Desktop App:

Web:

• I'm not sure what it looks like on Android

The expected result listed in the original description was that we should add ... at the end of the text field. In general, we aim to have behavior and design stay as consistent as possible across all platforms. Did we intentionally make it so that it worked differently on different platforms, or is that a bug?

[0xmiros]

This is iOS native issue only

... is iOS specific feature on single line text input. Other platforms don't add this at the end.
I also described this in PR Test/QA step:

[sakluger]

That makes sense!

I've paid out everyone, and included the 50% efficiency bonus for the Contributor and C+ payments.

I'm not closing out the issue quite yet, since I need to make sure we update our regression tests correctly.

[sakluger]

Created a GH issue to update TestRail steps.

@mollfpr @yuwenmemon, before I close out the issue, do you know if any previous PR caused this bug, or was this always the behavior and we just caught it for the first time?

[mollfpr]

@sakluger Sorry, I forgot to fill out the checklist. Probably from this #7594.

we just caught it for the first time?

I believe so.

[sakluger]

Thanks! The second item in the checklist is The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Could you please comment on that PR to explain why you think it caused this bug?

[mollfpr]

Sure, I’ll comment on that ASAP.

[mollfpr]

@sakluger Done #7594 (comment)

[parasharrajat]

Did we confirm the expected Result for this issue on the public channel? @mollfpr can you please share that discussion details?

[mollfpr]

I haven't opened a discussion about the expected result but it's a regression from adding the textAlign. I think the expected result is confirmed #13802 (comment) cc @sakluger.

I addressed my concern about removing textAlign in #13802 (comment), and I opened a discussion about that here.

[sakluger]

All done here, thanks everyone!