-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App window flashes at App launch on Android #13815
Comments
@Julesssss isn't this a duplicate report of what we encountered while solving #8236, specifically this comment in Slack? Not going to triage until we align on whether this is a bug or not. |
I and Jason had a 1:1 call and we concluded that this is a different issue than what the team discussed before. As far as I understood, the previous issue was related to the status bar color, but this one is related to the App window background. Here is a screen recording with the current issue: Screen_Recording_20221223_203544_New.Expensify.mp4As you can see, after killing the App and opening it again, the App screen is white and then becomes dark. @Julesssss Related to the status bar and also navigation bar. Have we considered to make the App render behind them and add a padding according to the bars height, to make sure that the App content does not overlap with the bars content? I guess the challenge is when the screen background changes, we have to delegate to the native code to update the activity background color as well, but maybe we could do some brainstorming and find a robust and scalable solution to support this. It would be a great achievement if we raise the Android App ui to the level of the iOS App. |
Super productive call, thank you! Yeah it seems like we still have a couple of improvements left to make when it comes to Android – whether it's the status bar on app load, the background color, the app icon, as well as the bottom border where the swipe action happens. All of those seem to either flash white or are permanently white, so it's inconsistent with the overall branding and our official colors. I agree this is a good one to keep internal, at least until we have a better sense of scope and next steps. |
@cristipaval is out for this week, but he has a good plan for the path forward and this bug is still young, so I'm going to keep him assigned. |
Waiting for @Julesssss, he had some health emergencies, he'll be online tomorrow. One thing I want to put down here, is that we're about to add the ability for the user to choose between light/dark themes. We need to find a solution for the App window to instantly set the background according to the user preference. |
Yeah, I agee and have come up with many solutions but unfortunately none of them are ideal. Will be looking into this again soon. |
Interestingly, I'm not seeing this issue on Android 13. I'm on app version WhatsApp.Video.2023-01-05.at.10.39.17.mp4Did I miss something? Else I wonder if this is a device-specific issue. |
Could you switch the theme in your phone settings? Set light theme if possible and try again. I wonder if this is related to the theme of the phone settings. |
Ah, good guess. But this still occurs in light mode: screen-20230105-160435.mp4 |
Closing this issue per this Slack convo. We're handling it elsewhere. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Splash screen should have the dark background
Actual Result:
Splash screen flashes, from white to dark background
Workaround:
None
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1671685986662779
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: