Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$4000] Logo shifts to bottom (Bootsplash) when launched - reported by Ekram Khan #8236

Closed
mvtglobally opened this issue Mar 19, 2022 · 144 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented Mar 19, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app

Expected Result:

It shifts to bottom

Actual Result:

It should not shift

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Android (Android 10 (POCO X3)

Version Number: 1.1.40-0
Reproducible in staging?: need repro
Reproducible in production?: need repro
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

New.Expensify.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Emrankhan & @aneequeahmad
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1644913657527229

View all open jobs on GitHub

@mvtglobally mvtglobally added the Needs Reproduction Reproducible steps needed label Mar 19, 2022
@MelvinBot MelvinBot added the Monthly KSv2 label Mar 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2022

@mvtglobally, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Jun 6, 2022
@mvtglobally mvtglobally reopened this Aug 29, 2022
@mvtglobally mvtglobally added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

Triggered auto assignment to @strepanier03 (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed AutoAssignerTriage Auto assign issues for triage to an available triage team member Monthly KSv2 labels Aug 29, 2022
@mvtglobally
Copy link
Author

mvtglobally commented Aug 29, 2022

Additional info here
https://expensify.slack.com/archives/C01GTK53T8Q/p1660111267974929

Image.from.iOS.12.MP4

@strepanier03
Copy link
Contributor

I can recreate it, except my logo (on android) shifts down and then back up so it looks like it bounces. My app loads so quickly that I can't capture it with screens either.

Either way, it's reproducible and the videos above illustrate the behavior well. Sending on.

@strepanier03 strepanier03 removed their assignment Aug 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

Triggered auto assignment to @Luke9389 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Luke9389
Copy link
Contributor

Agh! That's gross.

@Luke9389 Luke9389 added the External Added to denote the issue can be worked on by a contributor label Aug 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@NicMendonca
Copy link
Contributor

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 30, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 30, 2022

Current assignee @Luke9389 is eligible for the Exported assigner, not assigning anyone new.

@strepanier03

This comment was marked as outdated.

@strepanier03
Copy link
Contributor

I can't interact with the previous job that was created for this GH. I'm going to create a new one now and share links soon.

@strepanier03
Copy link
Contributor

@Santhosh-Sellavel and @aimane-chnaif - Please apply for the job HERE and let me know when you do so I can go in and accept/pay.

@ekramkhan66 - Please apply for the reporting payment HERE and let me know when you do so I can accept/pay.

@strepanier03
Copy link
Contributor

strepanier03 commented Dec 7, 2022

@aneequeahmad
Copy link
Contributor

@strepanier03 I'm eligible for reporting bonus as well.

@aimane-chnaif
Copy link
Contributor

@strepanier03 I am also eligible for C+ payment for internal PR review

@ekramkhan66
Copy link

@strepanier03 applied. Thanks!

@strepanier03
Copy link
Contributor

@aneequeahmad can you please share a Slack link for where you reported this? I have the link in the OG comment but it's to a report from Ekram Khan.

@aimane-chnaif
Copy link
Contributor

@strepanier03 applied. thanks

@aneequeahmad
Copy link
Contributor

@strepanier03 here is the link to the slack bug report https://expensify.slack.com/archives/C01GTK53T8Q/p1660111267974929

@strepanier03
Copy link
Contributor

Thank you for that link @aneequeahmad.

After looking at this more closely it looks like you reported on August 9th and it was marked a dupe:
2022-12-08_19-34-27

The original report by @ekramkhan66 was done on February 15:
2022-12-08_19-34-47

@strepanier03
Copy link
Contributor

I double-checked and confirmed that we only pay the first bug reporter. Thanks for raising this @aneequeahmad so I could confirm the information but at this time we will only be paying the original bug reporter.

@strepanier03
Copy link
Contributor

I've accepted all three applications for @ekramkhan66 @aimane-chnaif and @Santhosh-Sellavel, I'll check in later in my day and pay out who I can. Thank you all!

@Santhosh-Sellavel
Copy link
Collaborator

Thanks, @strepanier03!

@aneequeahmad
Copy link
Contributor

@strepanier03 Actually this bug wasn't reproducible and was closed when intially reported.

@strepanier03
Copy link
Contributor

Thank you @aneequeahmad, I've raised this internally to get some agreement and I'll update you once that convo wraps up, sorry for the delay!

@strepanier03
Copy link
Contributor

I'll keep this open for now but confirming I've paid the contracts for @aimane-chnaif @Santhosh-Sellavel and @ekramkhan66.

@strepanier03
Copy link
Contributor

@aneequeahmad - Please apply for the job here and I'll check tomorrow to accept and send the contract back to you. Cheers!

@shoaibarif244
Copy link

@mvtglobally
The requirement is to move the logo toward the bottom of the splash screen when the user opens the app.
[Solution]: I'll fix this issue using the Animated Library of react-native.

@shoaibarif244

This comment was marked as off-topic.

@Julesssss
Copy link
Contributor

@shoaibarif244 this issue has already been resolved, please review the contributing guidelines.

@strepanier03
Copy link
Contributor

Waiting for final pay out for @aneequeahmad and then ready to close.

@aneequeahmad
Copy link
Contributor

@strepanier03 I applied for the job. Thank you for mentioning

@strepanier03
Copy link
Contributor

Great thank you @aneequeahmad, I have accepted it and will check tomorrow to pay the contract. I am offline the rest of the day unexpectedly.

@strepanier03
Copy link
Contributor

Final payment made, going to close this one out now. Thank you to all involved!

@ekramkhan66
Copy link

I just tested the latest version, and it seems like the issue is not fixed.

Android (Poco X3)

Screenrecorder-2022-12-20-14-49-46-340.mp4

@Julesssss
Copy link
Contributor

I just tested the latest version, and it seems like the issue is not fixed.

This is a specific device, with a custom Android ROM. It's a separate issue, and most likely one that we won't prioritize solving at the moment as it occurs on a very small fraction of user devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests