Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-01-02 #13933

Closed
10 tasks done
OSBotify opened this issue Jan 2, 2023 · 7 comments
Closed
10 tasks done

Deploy Checklist: New Expensify 2023-01-02 #13933

OSBotify opened this issue Jan 2, 2023 · 7 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 2, 2023

Release Version: 1.2.47-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 2, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 2, 2023
@OSBotify
Copy link
Contributor Author

OSBotify commented Jan 2, 2023

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.47-0 🚀

@mvtglobally
Copy link

PR #13874 is failing #13951

@mvtglobally
Copy link

@roryabraham Regression is completed

Blocker #13951

@roryabraham
Copy link
Contributor

#13951 got demoted. Checking it off

@roryabraham
Copy link
Contributor

Also checking off the PR that caused the regression: #13874

@roryabraham
Copy link
Contributor

I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression

Seeing a spike in report switching on Android, but I think that metric includes the time for API requests to complete, so it could have been caused by a single user with a very slow network connection. I'm going to go ahead and ignore that spike for now.

@roryabraham
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants