Fix styled text treated as an emoji #13905

bernhardoj · 2022-12-30T06:59:49Z

Details

(A) When we send a styled text (italic, bold, or any styling) from another website, our current EMOJIS regex matches the text as an emoji, and because we set the font size bigger for emoji only messages, the styled text also gets bigger.

And there is also an additional issue (B) where when we copy emoji only messages by selecting it from the sent message and send it again, the emoji font size is not big (only possible happens on web).

Fixed Issues

$ #13823
PROPOSAL: #13823 (comment)

Tests

(A)

Copy styled text generated from https://lingojam.com/ItalicTextGenerator
Open any report
Paste the text to the composer and send it
Verify the text has a normal size

(B-web only)

Send an emoji-only message
Notice the font size of it
Copy the sent message (by selecting it from right to left, not from the context menu)
Paste to composer and send it again
Verify the sent emoji-only message has the same font size

Verify that no errors appear in the JS console

Offline tests

(A)

Copy styled text generated from https://lingojam.com/ItalicTextGenerator
Open any report
Paste the text to the composer and send it
Verify the text has a normal size

(B-web only)

Send an emoji-only message
Notice the font size of it
Copy the sent message (by selecting it from right to left, not from the context menu)
Paste to composer and send it again
Verify the sent emoji-only message has the same font size

QA Steps

(A)

Copy styled text generated from https://lingojam.com/ItalicTextGenerator
Open any report
Paste the text to the composer and send it
Verify the text has a normal size

(B-web only)

Send an emoji-only message
Notice the font size of it
Copy the sent message (by selecting it from right to left, not from the context menu)
Paste to composer and send it again
Verify the sent emoji-only message has the same font size

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2022-12-28.at.18.37.51.mov

Mobile Web - Chrome

328711.t.mp4

Mobile Web - Safari

Screen.Recording.2022-12-30.at.08.21.11.mp4

Desktop

Screen.Recording.2022-12-29.at.20.19.40.mov

iOS

Screen.Recording.2022-12-29.at.21.33.55.mov

Android

328706.t.mp4

melvin-bot · 2022-12-30T06:59:54Z

@AndrewGable @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thesahindia · 2022-12-30T15:39:42Z

src/CONST.js

@@ -455,7 +455,7 @@ const CONST = {

    EMOJI_FREQUENT_ROW_COUNT: 3,

-    EMOJI_INVISIBLE_CODEPOINTS: ['fe0f', '200d'],
+    EMOJI_INVISIBLE_CODEPOINTS: ['fe0f', '200d', '2066'],


Now that we are adding LTR unicode here, I think it would be better to rename it to just INVISIBLE_CODEPOINTS

thesahindia · 2022-12-30T15:45:48Z

tests/unit/EmojiTest.js

@@ -76,6 +76,21 @@ describe('EmojiTest', () => {

        // Given an input when we check only multiple emojis with additional whitespace, then it should return false
        expect(EmojiUtils.containsOnlyEmojis('😄  👋')).toBe(true);
+
+        // Given an emoji with a LTR unicode, when when we check if it contains only emoji, then it should return true


Suggested change

// Given an emoji with a LTR unicode, when when we check if it contains only emoji, then it should return true

// Given an emoji with a LTR unicode, when we check if it contains only emoji, then it should return true

thesahindia · 2022-12-30T15:49:20Z

tests/unit/EmojiTest.js

+        expect(EmojiUtils.containsOnlyEmojis('\u2066😄')).toBe(true);
+    });
+
+    it('don\'t match for non emoji', () => {


Suggested change

it('don\'t match for non emoji', () => {

it('will not match for non emoji', () => {

bernhardoj · 2022-12-30T16:29:55Z

My IP has been whitelisted. Added the video for iOS mWeb and added some commits for the suggested changes.

thesahindia · 2022-12-30T18:55:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

thesahindia

Tests well for me!

C+ reviewed 🎀👀🎀

cc: @AndrewGable

melvin-bot · 2022-12-30T22:09:38Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2022-12-30T22:13:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-01-02T18:27:26Z

🚀 Deployed to staging by @AndrewGable in version: 1.2.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-01-04T02:56:06Z

🚀 Deployed to production by @roryabraham in version: 1.2.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

bernhardoj added 2 commits December 29, 2022 19:24

fix styled text treated as an emoji

5e35fab

ignore LTR unicode

ac141b9

bernhardoj requested a review from a team as a code owner December 30, 2022 06:59

melvin-bot bot requested review from AndrewGable and thesahindia and removed request for a team December 30, 2022 06:59

thesahindia suggested changes Dec 30, 2022

View reviewed changes

bernhardoj added 2 commits December 30, 2022 08:15

change test comment and name

f22a8cd

change const name to be more general

ba3f1df

thesahindia approved these changes Dec 30, 2022

View reviewed changes

AndrewGable approved these changes Dec 30, 2022

View reviewed changes

AndrewGable merged commit 1b4bc34 into Expensify:main Dec 30, 2022

OSBotify mentioned this pull request Jan 2, 2023

Deploy Checklist: New Expensify 2023-01-02 #13933

Closed

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix styled text treated as an emoji #13905

Fix styled text treated as an emoji #13905

bernhardoj commented Dec 30, 2022 •

edited

Loading

melvin-bot bot commented Dec 30, 2022

thesahindia Dec 30, 2022

thesahindia Dec 30, 2022

thesahindia Dec 30, 2022

bernhardoj commented Dec 30, 2022

thesahindia commented Dec 30, 2022

thesahindia left a comment

melvin-bot bot commented Dec 30, 2022

OSBotify commented Dec 30, 2022

OSBotify commented Jan 2, 2023

OSBotify commented Jan 4, 2023

	// Given an emoji with a LTR unicode, when when we check if it contains only emoji, then it should return true
	// Given an emoji with a LTR unicode, when we check if it contains only emoji, then it should return true

	it('don\'t match for non emoji', () => {
	it('will not match for non emoji', () => {

Fix styled text treated as an emoji #13905

Fix styled text treated as an emoji #13905

Conversation

bernhardoj commented Dec 30, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 30, 2022

thesahindia Dec 30, 2022

Choose a reason for hiding this comment

thesahindia Dec 30, 2022

Choose a reason for hiding this comment

thesahindia Dec 30, 2022

Choose a reason for hiding this comment

bernhardoj commented Dec 30, 2022

thesahindia commented Dec 30, 2022

Reviewer Checklist

Screenshots/Videos

thesahindia left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 30, 2022

OSBotify commented Dec 30, 2022

OSBotify commented Jan 2, 2023

OSBotify commented Jan 4, 2023

bernhardoj commented Dec 30, 2022 •

edited

Loading