[hold for payment 2023-01-30] Profile picture on profile page should have 0 px padding or margin from top navigation

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open the app
2. Open settings and check the padding from top navigation for profile image
3. Open Workspaces
4. Open any Workspace and check the margin from top navigation for Workspace profile
5. Open general settings and check the margin from top navigation for Workspace profile
6. Open any report
7. Click on any user name and check the padding from top navigation for user profile
8. Open settings
9. Open profile and check the padding or margin from top navigation for profile image

Expected Result:

All instances where the Profile image appears in the app should have a consistent amount of top padding.

Actual Result:

Profile image has no margin or padding on the top.
Note: (Other pages with profile maintains 20 px margin or padding from navigation)

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.51-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673281072815909

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b073cc0e3a5005d6
• Upwork Job ID: 1613974508062380032
• Last Price Increase: 2023-01-13

[joekaufmanexpensify]

Discussing here.

[joekaufmanexpensify]

Working on triaging this:

From this SO: https://stackoverflow.com/c/expensify/questions/14418

• The "bug" is actually a bug: Y
• The bug is not a duplicate report of an existing GH (close the GH and add any novel details to the original GH instead): N/A
• The bug is reproducible, following the reproduction steps: Y
• If you're unable to reproduce the bug, add the Needs reproduction label. Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.: N/A
• The GH template is filled out as fully as possible -- this means the GH body and title are clear (ie. could an external contributor understand it and work on it?): Y
• The GH was created by an Expensify employee or a QA tester: Y
• If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it's better to wait, close the GH & provide this justification: N/A
• If there's a link to Slack, check the discussion to see if we decided not to fix it: N/A
• Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label: Going to keep this internal.

[joekaufmanexpensify]

@arosiclair once this is triaged, I'm thinking you want to take this one and keep it internal?

[arosiclair]

@arosiclair once this is triaged, I'm thinking you want to take this one and keep it internal?

Yup that's correct!

[joekaufmanexpensify]

Sounds good!

[joekaufmanexpensify]

Reproduced on web:

[joekaufmanexpensify]

Okay, this is reproduced. Before we proceed, discussing what the actual fix looks like here in the slack thread. Let's hold off on proceeding until we're crisp on that.

[joekaufmanexpensify]

Discussed in the slack thread, and the solution we want for fixing this bug is leaving no top padding on the profile page, and removing the top padding for the profile image on the Settings page, the workspace page, the workspace general settings page, and the details page accessed when clicking another user's profile image.

Updating the OP of the issue to make this clear, and then making this internal.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b073cc0e3a5005d6

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[joekaufmanexpensify]

All yours @arosiclair !

[joekaufmanexpensify]

Not overdue.

[joekaufmanexpensify]

Hm, not sure why the label is still there?

[joekaufmanexpensify]

Next step here is to begin the PR

[arosiclair]

Working on this today

[joekaufmanexpensify]

Okay, no C+ review done here, so no payment to them is needed. We implemented this internally, so no C payment as well. So the only payment we need to make here is the $250 reporting bonus to @dhanashree-sawant

[joekaufmanexpensify]

@eVoloshchak un-assigning as you didn't review the PR here.

[joekaufmanexpensify]

@dhanashree-sawant, contract sent for $250! We'll issue payment after the 7 day regression waiting period, on 2023-01-30.

[joekaufmanexpensify]

Besides that, only other step here is the BZ checklist. Not sure why it didn't get automatically created, so will add it manually!

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@arosiclair ] The PR that introduced the bug has been identified. Link to the PR:
• [@arosiclair] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@arosiclair ] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: LINK
• [@joekaufmanexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: Added to new design testing guidelines.

[arosiclair]

Finding it very hard to find when exactly the spacing on top of the profile page was removed. It definitely had some spacing originally, but the profile page history is long with a lot of layout changes. Since this is a low impact bug and we had a big redesign, I'll skip that part and just post a thread on how to possibly keep this from occurring again.

[joekaufmanexpensify]

Switching to daily as payment is due today.

[joekaufmanexpensify]

@dhanashree-sawant $250 sent and contract ended!

[joekaufmanexpensify]

Closed upwork job.

[joekaufmanexpensify]

Proposed new regression test here.

[joekaufmanexpensify]

Okay, ended up not creating a new regression test here. Since this is more design focused, I instead added it to the new design testing guidelines we're creating for applause.

[joekaufmanexpensify]

Closing as this is all set!