Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-01-20] (front-end) Sort reportActions by timestamp, then action type, then reportActionID #14211

Closed
roryabraham opened this issue Jan 10, 2023 · 3 comments
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@roryabraham
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem

If multiple reportActions of different types are created in the same millisecond, then there is currently nothing to guarantee that the CREATED action will appear first

Solution

Update the reportActions sorting function to ensure that we sort by three criteria instead of two:

  1. Timestamp first
  2. Action type
  3. reportActionID

View all open jobs on GitHub

@roryabraham roryabraham added Engineering Daily KSv2 Improvement Item broken or needs improvement. labels Jan 10, 2023
@roryabraham roryabraham self-assigned this Jan 10, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 10, 2023
@roryabraham roryabraham changed the title Sort reportActions by timestamp, then action type, then reportActionID (front-end) Sort reportActions by timestamp, then action type, then reportActionID Jan 10, 2023
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jan 10, 2023
@roryabraham
Copy link
Contributor Author

PR is ready for review: #14213

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jan 13, 2023
@melvin-bot melvin-bot bot changed the title (front-end) Sort reportActions by timestamp, then action type, then reportActionID [HOLD for payment 2023-01-20] (front-end) Sort reportActions by timestamp, then action type, then reportActionID Jan 13, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 19, 2023
@mallenexpensify mallenexpensify removed the Awaiting Payment Auto-added when associated PR is deployed to production label Jan 20, 2023
@mallenexpensify
Copy link
Contributor

Should this have auto-closed @roryabraham cuz it hit production a week ago? #14213 (comment)

Also, doesn't look like C+ reviewed so no payment is due, right

@roryabraham
Copy link
Contributor Author

Yep, looks like we're all set here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants