-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-30] [$250] Actions showing up in the workspace chat before the Created action #47895
Comments
Triggered auto assignment to @kadiealexander ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
Edited by proposal-police: This proposal was edited at 2024-08-23 03:56:38 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.All of those expense reports were created before your workspace chat for policy B so they are showing up above the created action What is the root cause of that problem?We're sorting the report actions based on timestamp and ID: App/src/libs/ReportActionsUtils.ts Line 776 in a3fc70c
What changes do you think we should make in order to solve the problem?Need to somehow shift the const createdActionIndex = sortedActions.findIndex((action) => action.actionName === 'CREATED');
if (createdActionIndex !== -1) {
sortedActions.unshift(sortedActions.splice(createdActionIndex, 1)[0]);
} |
Proposal Update
|
Job added to Upwork: https://www.upwork.com/jobs/~01e262549903248d36 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
@m-natarajan Can you share the video/screenshots? I don't know how to reproduce this issue. Thanks |
I think you can re-create it by doing the following.
|
@puneetlath I could not reproduce following the steps. Maybe it only happens when expenses are moved to domain group's policy, which is a BE bug. However, based on OP:
We should modify the FE to always show CREATED action first to prevent such issues in the future. |
@kadiealexander, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
ProposalIn view of this comment, I am changing my suggestion into a proposal if this is how we want to fix it. Please re-state the problem that we are trying to solve in this issue.Other report actions show up before created action if they have time earlier than the created action of the report. What is the root cause of that problem?We sort the reports based on report action created time first and only after this we prioritize the What changes do you think we should make in order to solve the problem?We can swap the order of these two conditions: App/src/libs/ReportActionsUtils.ts Lines 369 to 376 in a3fc70c
Then the What alternative solutions did you explore? (Optional)Earlier commentIf we swap the order of these two conditions: App/src/libs/ReportActionsUtils.ts Lines 369 to 376 in a3fc70c
the This used to be the case until it was changed here by @roryabraham. The issue for this PR also mentions that it was intended to fix the same issue of ensuring the |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@kadiealexander, @dukenv0307 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Yes, I agree with this. This makes sense to me. |
@roryabraham Can you check this comment |
@kadiealexander @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-30. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Reassigning for someone to handle payment as I'm OOO for the next two weeks. |
Triggered auto assignment to @puneetlath ( |
@puneetlath, @stitesExpensify, @c3024, @dukenv0307 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@c3024 has been paid. @dukenv0307 waiting on the checklist for you. |
BugZero Checklist:
Regression test:
Do we 👍 or 👎 |
@puneetlath added the checklist |
@puneetlath, @stitesExpensify, @c3024, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@puneetlath, @stitesExpensify, @c3024, @dukenv0307 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it! |
@puneetlath, @stitesExpensify, @c3024, @dukenv0307 10 days overdue. I'm getting more depressed than Marvin. |
Whoops, this one fell through the cracks. Regression test here: https://github.com/Expensify/Expensify/issues/444024 All paid. Thanks y'all! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: n/a
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1724257201383519
Action Performed:
Expected Result:
Actions should not show in the workspace chat before the created action
Actual Result:
All of those expense reports were created before your workspace chat for policy B so they are showing up above the created action
The text was updated successfully, but these errors were encountered: