Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] [HOLD for payment 2023-02-02] IOU - Search with $ sign does not work #14229

Closed
6 tasks
kavimuru opened this issue Jan 11, 2023 · 15 comments
Closed
6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kavimuru
Copy link

kavimuru commented Jan 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Click on plus and open Request Money/Send Money
  4. Search currency by currency symbols like €, ¥, ₹ and see the results
  5. Search by $ and see the results

Expected Result:

When searching by $, results should only include currency with $ symbol in it like USD, AUD

Actual Result:

All currencies are displayed in the search results

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.52-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

dollar.not.searchable.issue.mp4
az_recorder_20230111_181727.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1673432441812079

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c47b299424b54c8c
  • Upwork Job ID: 1621122105930612736
  • Last Price Increase: 2023-02-09
@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 11, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2023
@mateocole
Copy link

Is this something we want to fix internally?

@melvin-bot melvin-bot bot removed the Overdue label Jan 18, 2023
@iwiznia
Copy link
Contributor

iwiznia commented Jan 18, 2023

Not necessarily... if I can't get some time tomorrow to start on it, I'll make it externalk

@mateocole
Copy link

mateocole commented Jan 25, 2023

@iwiznia upwork is bugging out rn when I try to create a new job, but I'll create an external job for this tomorrow.

Edit- actually once you add external, it will auto make a job. ill wait for you to confirm

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jan 26, 2023
@melvin-bot melvin-bot bot changed the title IOU - Search with $ sign does not work [HOLD for payment 2023-02-02] IOU - Search with $ sign does not work Jan 26, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 26, 2023
@mateocole
Copy link

mateocole commented Feb 2, 2023

What payment(s) are owed on this? only the reporting? (accidentally marked external, removed it and deleted upwork post, going to wait for ioni on that)

@mateocole mateocole added the External Added to denote the issue can be worked on by a contributor label Feb 2, 2023
@melvin-bot melvin-bot bot unlocked this conversation Feb 2, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-02-02] IOU - Search with $ sign does not work [$1000] [HOLD for payment 2023-02-02] IOU - Search with $ sign does not work Feb 2, 2023
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 2, 2023
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 2, 2023
@mateocole mateocole removed the External Added to denote the issue can be worked on by a contributor label Feb 2, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Feb 2, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Feb 2, 2023
@mateocole mateocole removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 2, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Feb 2, 2023
@Expensify Expensify deleted a comment from melvin-bot bot Feb 2, 2023
@mateocole mateocole changed the title [$1000] [HOLD for payment 2023-02-02] IOU - Search with $ sign does not work [HOLD for payment 2023-02-02] IOU - Search with $ sign does not work Feb 2, 2023
@iwiznia
Copy link
Contributor

iwiznia commented Feb 2, 2023

We need to pay eVoloshchak for the review

@dhanashree-sawant
Copy link

Hi @mateocole , the payment date was 02-02-2023, can you have a look once into it once you are available?

@melvin-bot melvin-bot bot added the Overdue label Feb 6, 2023
@mateocole
Copy link

mateocole commented Feb 7, 2023

yeah was ooo yesterday, and it doesnt look like an upwork was made to pay, and I am still running into an error trying to create a job
image

contacted upwork

will keep you up to date on this payment, apologies

@melvin-bot melvin-bot bot removed the Overdue label Feb 7, 2023
@dhanashree-sawant
Copy link

That's okay, thanks for the update.

@mateocole mateocole added the External Added to denote the issue can be worked on by a contributor label Feb 9, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-02-02] IOU - Search with $ sign does not work [$1000] [HOLD for payment 2023-02-02] IOU - Search with $ sign does not work Feb 9, 2023
@MelvinBot
Copy link

Current assignee @mateocole is eligible for the External assigner, not assigning anyone new.

@MelvinBot
Copy link

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 9, 2023
@MelvinBot
Copy link

Current assignee @iwiznia is eligible for the External assigner, not assigning anyone new.

@mateocole mateocole removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 9, 2023
@mateocole
Copy link

Okay @dhanashree-sawant and @eVoloshchak can you both apply here:
https://www.upwork.com/jobs/~0173cdf12476b17683

@dhanashree-sawant
Copy link

@mateocole yes , applied

@mateocole
Copy link

Okay, sent contract

@dhanashree-sawant
Copy link

Thanks, Accepted the contract

@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2023
@melvin-bot melvin-bot bot removed the Overdue label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

9 participants