Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching currency with symbols like *,(,) crashes native apps and triggers console error in web #14415

Closed
6 tasks
kavimuru opened this issue Jan 19, 2023 · 4 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Open Request Money/Send Money/Split Bill
  4. Click on currency
  5. In search, try to search with either of the symbols: *,(,)

Expected Result:

It should display that symbol in search box without any error

Actual Result:

It crashes the app on android and does not display the symbol on windows and mac and it also displays console error 'Invalid regular expression'

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.56-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

android.crash.on.search.mp4
Invalid.expression.console.mp4
az_recorder_20230119_142156.mp4

Untitled

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674124529838879

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 19, 2023

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 19, 2023
@laurenreidexpensify
Copy link
Contributor

laurenreidexpensify commented Jan 20, 2023

Oh weird - I can't reproduce this on web, Mweb or Android, here's my attempt on android now -

2023-01-20_09-21-22

@laurenreidexpensify laurenreidexpensify removed the Bug Something is broken. Auto assigns a BugZero manager. label Jan 20, 2023
@laurenreidexpensify laurenreidexpensify removed their assignment Jan 20, 2023
@laurenreidexpensify laurenreidexpensify added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 20, 2023
@laurenreidexpensify
Copy link
Contributor

@mateocole I am OOO next week so reassigning, can you continue to troubleshoot this pls.

@iwiznia
Copy link
Contributor

iwiznia commented Jan 20, 2023

Dupe of #14229

@iwiznia iwiznia closed this as completed Jan 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

4 participants