[Fabric Rollout] iOS - Second keyboard opens when you click on the cursor in Request money

[dylanexpensify]

Action Performed:

1. Launch App
2. Enter email. password
3. Click the FAB button and select Request Money
4. Verify that the big number pad (BNP) page appears next
5. Tab on the cursor next to currency

Expected Result:

There should be only one keyboard

Actual Result:

Second keyboard opens when you click on the cursor in Request money

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• IOS / Native

Version Number: 1.2.49.0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5888070_cursor_request_0701.mp4

Issue reported by: Applause - Internal Team

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dylanexpensify]

Coming from here. Context here!

[j-piasecki]

I'm working on this.

[j-piasecki]

facebook/react-native#35878 should fix this issue upstream, I also added a patch for the time being here.

[JmillsExpensify]

Thanks @j-piasecki! I'll create another issue out of band so that we don't forget to update things once the upstream fix is live.

[JmillsExpensify]

Moved this to weekly since that's the speed this project is moving at.

[JmillsExpensify]

Sounds like we agreed on a GH project in the linked thread, though we still need to put that in motion. I'm pretty back up early this week, though, so unlikely I'll get back to this for a bit.

[j-piasecki]

@JmillsExpensify It seems like I cannot access the linked slack thread. Could you post the summary here or add me to the relevant channel?

[JmillsExpensify]

Oh sorry about that! Sure thing, we essentially decide that we were going to create a GH project that helps keep track of all our upstream fixes, forks, and what not so that we can better keep track of how to minimize what's specific to Expensify. So the project would have the following stages:

• Reviewing
• Merged in fork
• Merged upstream
• Released upstream and resolved

@roryabraham I'm going to go ahead and create this project, because I don't think one already exists. I believe we can also make it public for all too in this repo.

[JmillsExpensify]

Same same.

[JmillsExpensify]

Re-testing of Fabric is commencing soon.

[JmillsExpensify]

Same as above.

[JmillsExpensify]

Same same. Fabric roll out and testing is on-going.

[JmillsExpensify]

Same

[JmillsExpensify]

At a conference this week, not prioritizing this.

[j-piasecki]

It is working as expected when building the app from the current (WoLewicki@e12c1cf) andrew-fabric branch:

ios-request-money-keboard.mov

[JmillsExpensify]

Nice work! Let's close this one out then.