Skip to content

Commit

Permalink
Workaround for didScreenTransitionEnd being constantly false
Browse files Browse the repository at this point in the history
  • Loading branch information
j-piasecki committed Jun 20, 2023
1 parent 70992f2 commit e12c1cf
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/pages/iou/MoneyRequestModal.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import ONYXKEYS from '../../ONYXKEYS';
import withLocalize, {withLocalizePropTypes} from '../../components/withLocalize';
import compose from '../../libs/compose';
import * as OptionsListUtils from '../../libs/OptionsListUtils';
import FullScreenLoadingIndicator from '../../components/FullscreenLoadingIndicator';
// import FullScreenLoadingIndicator from '../../components/FullscreenLoadingIndicator';
import AnimatedStep from '../../components/AnimatedStep';
import ScreenWrapper from '../../components/ScreenWrapper';
import CONST from '../../CONST';
Expand Down Expand Up @@ -338,16 +338,17 @@ function MoneyRequestModal(props) {
const enableMaxHeight = DeviceCapabilities.canUseTouchScreen() && currentStep === Steps.MoneyRequestParticipants;
const bankAccountRoute = ReportUtils.getBankAccountRoute(props.report);

// TODO: investigate the didScreenTransitionEnd being false all the time
return (
<ScreenWrapper
includeSafeAreaPaddingBottom={false}
shouldEnableMaxHeight={enableMaxHeight}
>
{/* eslint-disable-next-line no-unused-vars */}
{({didScreenTransitionEnd, safeAreaPaddingBottomStyle}) => (
<>
<View style={[styles.pRelative, styles.flex1]}>
{!didScreenTransitionEnd && <FullScreenLoadingIndicator />}
{didScreenTransitionEnd && (
{/* {!didScreenTransitionEnd && <FullScreenLoadingIndicator />} */}
<>
{currentStep === Steps.MoneyRequestAmount && (
<AnimatedStep
Expand Down Expand Up @@ -420,7 +421,7 @@ function MoneyRequestModal(props) {
</AnimatedStep>
)}
</>
)}
{/* )} */}
</View>
</>
)}
Expand Down

0 comments on commit e12c1cf

Please sign in to comment.