Sign out - App is crashed after log out

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch the app
2. Log in with any account
3. Go to Setting
4. Type Sign out

Expected Result:

No crash when sign out the app

Actual Result:

App is crashed after log out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• iOS / native

Version Number: 1.2.57.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers): 5082211196

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230120_085820_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[marcochavezf]

👀

[marcochavezf]

This is the error happening on the local Android simulator after logging out:

Atm, I suspect the error is happening here, I commented out those lines and the error is gone.

I will come back in 2 hours to continue the investigation.

[marcochavezf]

PR up to fix it on react-native-onyx. Also, this error was reported here.

[marcochavezf]

PR up to bump the react-native-onyx version that fixes the log out issue in New Dot.

[luacmartins]

Closing this blocker since the fix was CPed to staging!

[mountiny]

Opening this to handle payment to @sobitneupane $1000 for review and testing #14450 (comment)

[MelvinBot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

@marcochavezf @kadiealexander this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[kadiealexander]

@sobitneupane I sent you a contract in Upwork, please let me know once you've accepted. :)

[sobitneupane]

@kadiealexander Thanks. Accepted the offer.

[kadiealexander]

Thanks @sobitneupane!! All paid.