Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security - Close account - App is crashed when closing the account #14447

Closed
2 tasks
kbecciv opened this issue Jan 20, 2023 · 5 comments
Closed
2 tasks

Security - Close account - App is crashed when closing the account #14447

kbecciv opened this issue Jan 20, 2023 · 5 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Jan 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with gmail account
  3. Navigate to Settings > Security
  4. Enter the email in the input and tap on "close account" button

Expected Result:

App is not crashed when closing the account

Actual Result:

App is crashed when closing the account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • iOS / native

Version Number: 1.2.57.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5904877_ios_crash_2001.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jan 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 20, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Expensify Expensify unlocked this conversation Jan 20, 2023
@mountiny
Copy link
Contributor

@chiragsalian Hopefully this PR should fix it Expensify/react-native-onyx#231

@0xmiros
Copy link
Contributor

0xmiros commented Jan 20, 2023

I confirmed this has the same root cause with #14437

213773644-4789808b-5d94-46b0-8030-a481aec4638e

@chiragsalian
Copy link
Contributor

chiragsalian commented Jan 20, 2023

This looks like a dupe of #14437. Closing this issue out but @marcochavezf can you test this flow as well when your App PR is ready. I imagine you'll need an App PR to bump the react-native-onyx version. Remember to apply CP-staging label 🙇‍♂️

@marcochavezf
Copy link
Contributor

marcochavezf commented Jan 21, 2023

Confirmed this is fixed in the PR that bumps the react-native-onyx version:

Screen.Recording.2023-01-20.at.18.13.34.mov

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants