Web -Connect Bank Account - Blank modal after KBA check

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Prerequisites: Go to OldDot, log in with a new applause.expensifail account, verify you see a payment type for WALLET with a deposit status of "Silver". Do not add a personal bank account. If already added, delete it.

1. Navigate to NewDot, log in with the previously created account and open a 1:1 conversation with any user
2. Click/tap on the + icon and select the "Send Money" option
3. Enter any amount and continue
4. Click on the button "Pay with Expensify"
5. Click Bank account and add a personal bank account using Wells Fargo credentials (Repro with Fidelity)
6. Once the bank account has been added, attempt to send money again
7. Verify that you're taken directly to the KYC verification
8. In the additional details form, enter first name "Alberta", last name "Bobbeth" and SSN as "3333". Enter any data for the other fields.
9. After getting error regarding SSN, don't change the SSN data and click Save & continue
10. KBA flow is triggered (flow to verify the identity via questions)
11. Select the first answer for every question (important otherwise the KBA check will fail)

Expected Result:

User should proceed to the Onfido verification flow

Actual Result:

Blank modal is displayed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Web / Chrome

Version Number: 1.2.57.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/3087583

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5908231_video_20.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0159b9a6a0a768f3db
• Upwork Job ID: 1623588390235365376
• Last Price Increase: 2023-02-09

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

@johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[johncschuster]

My bad on missing the ping here. Sorry team.

[neil-marcellini]

I'm able to reproduce this using a new @expensifail.com account, which automatically comes with a silver wallet. After I add a bank account in step 6 it sends me back to Plaid which seems like another error. I manually exited that flow and moved to step 7.

I'm not sure if this can be worked on externally so I'll ask in Slack. I have a full load of daily issues right now so if it's not external I'm going to ask if someone else can work on it.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0159b9a6a0a768f3db

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @thesahindia (Internal)

[MariaHCD]

Making this internal and taking over for @neil-marcellini (Slack thread here)

[MariaHCD]

Looking into this, it looks like the KYC wallet flow is not being triggered at all (related issue: #14945)

Screen.Recording.2023-02-09.at.4.06.05.PM.mov

Investigating further.

[MariaHCD]

Looks like we removed the Onyx key WALLET_ADDITIONAL_DETAILS_DRAFT here but it is still being used for the Onfido step:

App/src/pages/EnablePayments/EnablePaymentsPage.js

Lines 82 to 83 in d9a126d

	{currentStep === CONST.WALLET.STEP.ONFIDO && this.props.walletAdditionalDetailsDraft
	&& <OnfidoStep walletAdditionalDetailsDraft={this.props.walletAdditionalDetailsDraft} />}

App/src/pages/EnablePayments/OnfidoPrivacy.js

Lines 48 to 54 in d9a126d

	openOnfidoFlow() {
	BankAccounts.openOnfidoFlow(
	this.props.walletAdditionalDetailsDraft.legalFirstName,
	this.props.walletAdditionalDetailsDraft.legalLastName,
	this.props.walletAdditionalDetailsDraft.dob,
	);
	}

I think we don't need to use the additionalDetailsDraft at the OnfidoStep, we can just update the API command OpenOnfidoFlow to fetch these on the backend instead of relying on the frontend to pass these two parameters.

[MariaHCD]

Web and App PRs are still WIP but it looks like removing the usage of the Onyx key walletAdditionalDetailsDraft from the OnfidoStep worked 🎊

1. KYC is triggered when attempting to send money with a silver wallet

Screen.Recording.2023-02-10.at.5.10.55.PM.mov

2. KYC is triggered when attempting to pay an IOU with a silver wallet

Screen.Recording.2023-02-10.at.5.12.34.PM.mov

Next steps for me:

• Ensure the KBA flow works as expected and the user can proceed to activate their wallet
• Fix the Continue button on the OnfidoPrivacy page and on the IdologyQuestions page to be fixed at the bottom of the page instead of in the middle
• Fix issue where adding a PBA as part of sending money redirects to the payments page as well as re-triggers Plaid.

[MariaHCD]

Resuming work on the PRs this week

[MelvinBot]

@johncschuster, @MariaHCD, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MariaHCD]

Both Web and App PRs were merged and deployed to production. Created a separate issue to look into why Plaid is being re-triggered after adding a PBA: #15202

(Just realized I didn't tag @thesahindia for review on the App PR, sorry!)

I think we should be all good here.