Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow first and last name in send money additional details to be completely deleted and refactor to use Form #13170

Merged
merged 68 commits into from
Jan 11, 2023
Merged

Allow first and last name in send money additional details to be completely deleted and refactor to use Form #13170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
b992707
Add wallet details ONYX form
Nov 29, 2022
5d96431
Import Form
Nov 29, 2022
f29aa50
Add Form element
Nov 29, 2022
e86cddc
Delete FormScrollView element
Nov 29, 2022
d73c701
Remove onChangetText from legalFirstName and legalLastName text inputs
Nov 30, 2022
137a0bd
Getting rid of walletAdditionalDetailsDraft
Nov 30, 2022
c62f5e6
Remove onFieldChange and onTextChange props
Nov 30, 2022
9291b90
Create INPUT_IDS const
Nov 30, 2022
bf73345
Bind validate function to class
Nov 30, 2022
6d60f2a
Export the new ONYX key
Nov 30, 2022
1b3e04c
Add other inputIDs
Dec 1, 2022
a53ba4b
Save onyx draft to props
Dec 1, 2022
f00c9ee
Use inputIDs in elements and save drafts of values
Dec 1, 2022
9a2c97c
Update some of the validation steps
Dec 1, 2022
ab46916
Use defaultValues for address
Dec 1, 2022
bd536f8
Add address inputIDs
Dec 1, 2022
325544a
Use better propType definition for addressForm errors
Dec 1, 2022
e163545
Use passed values in validate
Dec 1, 2022
d902722
Delete unused variables
Dec 1, 2022
f2521a7
Do not save a draft of SSN number
Dec 1, 2022
8ee48df
Do not save walletAdditionalDetailsFormDraft onyx object to walletAdd…
Dec 1, 2022
7b1a7eb
Set address for imputKeys, and let the errors populate correctly
Dec 1, 2022
71cf3f5
Update getFirstName, getLastName, and getPhoneNumber and get rid of d…
Dec 1, 2022
4aa4572
Remove unnecessary default values for address
Dec 1, 2022
2666df6
Fix typo
Dec 1, 2022
400b672
Validate last name correctly
Dec 1, 2022
9b10dcb
Remove unnecessary getErrorText and errorText props
Dec 1, 2022
b2ad981
Remove unused clearError
Dec 1, 2022
3d5f023
Remove unused getErrors
Dec 1, 2022
c2b9d62
Remove unused formHelper
Dec 1, 2022
f2914eb
Remove unused imports
Dec 1, 2022
98e4354
Pass values to activateWallet correctly
Dec 1, 2022
d1a4e4d
Update documentation
Dec 1, 2022
af7b892
Remove unused walletAdditionalDetailsDraft prop type definition
Dec 1, 2022
6b15a96
Fixing age and 9 digit ssn errors
Dec 1, 2022
dac640e
Make sure values get sent to validate when activateWallet is called
Dec 1, 2022
2ead055
Do not use FORM key for walletAdditionalDetails prop
Dec 1, 2022
d08cb59
Do not pass unnecessary prop to AdditionalDetailsStep
Dec 1, 2022
7fc0831
Remove unnecessary validate from activateWallet
Dec 1, 2022
a63dfce
Validating inputs when component updates
Dec 1, 2022
24e0050
Merge branch 'main' of github.com:Expensify/App into joel_detailsForm
Dec 1, 2022
40bc5fc
Getting the error message to display when it is not recognized
Dec 1, 2022
c56716c
Make sure we default to the correct error message
Dec 1, 2022
1528554
Make sure we clear the server errors before making a call to the serv…
Dec 1, 2022
0642563
Make sure we only display the error message if it is a string
Dec 1, 2022
4f53259
Make sure the walletAdditionalDetailsDraft object gets set because it…
Dec 2, 2022
e4f1471
Use the original ONYX key
Dec 2, 2022
d1bd5c1
Handle server errors with baked in form functionality
Dec 2, 2022
12875d1
Load walletAdditionalDetails with stored values
Dec 2, 2022
a49a072
Linting error
Dec 2, 2022
c9110e2
Merge branch 'main' of github.com:Expensify/App into joel_detailsForm
Dec 2, 2022
1771b19
Pass the dob to the api in the correct format from all platforms
Dec 5, 2022
52ffca2
Linting
Dec 6, 2022
668750e
Merge branch 'main' of github.com:Expensify/App into joel_detailsForm
Dec 6, 2022
42ee09e
Merge branch 'main' of github.com:Expensify/App into joel_detailsForm
Dec 16, 2022
cabc5e8
Fix conflicts
Dec 20, 2022
bd40c46
Add style to form
Dec 21, 2022
a2c1fe1
Use inline function calls instead of adding new methods
Dec 21, 2022
a0e5df5
Capitalize constant names
Dec 21, 2022
7a237cf
Remove maximumDate
Dec 21, 2022
3bc4c9a
Merge branch 'main' of github.com:Expensify/App into joel_detailsForm
Jan 4, 2023
e839e3c
Get rid of unnecessary view elements
Jan 4, 2023
1f47942
Spacing
Jan 4, 2023
6e316ca
Undo the caps naming because it is passed as a prop to the AddressFor…
Jan 4, 2023
cb62efb
Fix conflict
Jan 4, 2023
8cb5f37
Missed a conflict
Jan 4, 2023
bfffb9c
Remove unused constant
Jan 5, 2023
b1cd76e
Show error if nothing is included in the address street
Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/ONYXKEYS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ export default {
// Stores information about additional details form entry
WALLET_ADDITIONAL_DETAILS: 'walletAdditionalDetails',

// Stores values put into the additional details step of the wallet KYC flow
WALLET_ADDITIONAL_DETAILS_DRAFT: 'walletAdditionalDetailsDraft',

// Object containing Wallet terms step state
WALLET_TERMS: 'walletTerms',

Expand Down
8 changes: 0 additions & 8 deletions src/libs/actions/Wallet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,6 @@ function openEnablePaymentsPage() {
API.read('OpenEnablePaymentsPage');
}

/**
* @param {Object} keyValuePair
*/
function updateAdditionalDetailsDraft(keyValuePair) {
Onyx.merge(ONYXKEYS.WALLET_ADDITIONAL_DETAILS_DRAFT, keyValuePair);
roryabraham marked this conversation as resolved.
Show resolved Hide resolved
}

/**
* @param {String} currentStep
*/
Expand Down Expand Up @@ -317,7 +310,6 @@ export {
openInitialSettingsPage,
openEnablePaymentsPage,
setAdditionalDetailsErrors,
updateAdditionalDetailsDraft,
setAdditionalDetailsErrorMessage,
setAdditionalDetailsQuestions,
updateCurrentStep,
Expand Down
Loading