[HOLD for payment 2023-02-24] New message green line appears after a brief moment when opening the app from background

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Mark as read first message then swipe from bottom then open the app again.
3. Notice that mark as read line disappears then appears again.

Expected Result:

Mark as read line should consistently.

Actual Result:

Mark as read line disappears then appears again.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• iOS / native

Version Number: 1.2.58-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

MZBZ5035.MP4

RPReplay_Final1674551444.MP4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1674552168801719

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ecfec059338b828f
• Upwork Job ID: 1623441417954881536
• Last Price Increase: 2023-02-08

[MelvinBot]

@puneetlath this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MelvinBot]

@puneetlath 12 days overdue now... This issue's end is nigh!

[puneetlath]

I think this likely needs to be Internal.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01ecfec059338b828f

[MelvinBot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eVoloshchak (Internal)

[gedu]

Hi, Eduardo from Callstack, can I take this one?

[mountiny]

@gedu as mentioned in Slack feel free to give this a try but there is a chance it requires backend changes, nevertheless post your findings!

[gedu]

Proposal

Please re-state the problem that we are trying to solve in this issue.
After marking a chat message as unread, when you put the app into the background and open it again, the new green line hide and shows up again

What is the root cause of that problem?
In ReportsActionView we are subscribing to Visibility.onVisibilityChange and as soon the app becomes visible we are cleaning the newMarkerReportActionID, when that happens the new green line disappears, and later when the list is fully visible, it checks if was manually marked didManuallyMarkReportAsUnread and it shows up the green line again

What changes do you think we should make in order to solve the problem?
In ReportsActionView we are subscribing to Visibility.onVisibilityChange check if still unread before clearing the newMarkerReportActionID instead of assuming that the user already read the message

greenLine-aftervisible.mp4

greenLine-aftervisible-hide.mp4

What alternative solutions did you explore? (Optional)
Maybe instead of using a ReportActionID using the lastReadTime, so we avoid to use kind of 2 properties to mark a message as unread, this will require a lot of code changes and testing to avoid regression bugs or breaking the working features

[puneetlath]

Ah yes that is interesting. The comment says "If the app user becomes active and they have no unread actions" but then we don't actually check whether or not the chat is unread before clearing the marker. That solution sounds good to me. @eVoloshchak what do you think?

[mountiny]

@gedu I think this solution makes sense, thank you, I would say you can go ahead and create a PR for this. You got two approvals 🙌

[gedu]

I have read the CLA Document and I hereby sign the CLA

[MelvinBot]

@puneetlath, @gedu, @eVoloshchak Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eVoloshchak]

Not overdue, PR was deployed to production 3 days ago

[mountiny]

Updated the title to reflect this.

[puneetlath]

@eVoloshchak sent you a contract offer.

[eVoloshchak]

Offer accepted👌

[puneetlath]

All done. Thanks everyone!

[hungvu193]

@puneetlath please invite me, I'm the reporter

[eVoloshchak]

@puneetlath, the PR was merged within 2 business days. I didn't review proposals, only the PR, but it looks like @gedu might be eligible for the bonus

[mountiny]

Just gonna reopen this so we dont forget to handle the reporting bonus

[puneetlath]

@puneetlath, the PR was merged within 2 business days. I didn't review proposals, only the PR, but it looks like @gedu might be eligible for the bonus

@eVoloshchak in this case, this was handled by a vendor contributor from Callstack, so the process is more similar to our Internal PR process.

@hungvu193 sorry for forgetting about you! Can you apply here: https://www.upwork.com/jobs/~01ecfec059338b828f

For me: https://www.upwork.com/ab/applicants/1623441417954881536/applicants

[hungvu193]

@puneetlath, the PR was merged within 2 business days. I didn't review proposals, only the PR, but it looks like @gedu might be eligible for the bonus

@eVoloshchak in this case, this was handled by a vendor contributor from Callstack, so the process is more similar to our Internal PR process.

@hungvu193 sorry for forgetting about you! Can you apply here: https://www.upwork.com/jobs/~01ecfec059338b828f

For me: https://www.upwork.com/ab/applicants/1623441417954881536/applicants

Thank you, I've just applied!

[puneetlath]

Paid! Should actually be done now. Thanks everyone!