Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Web - Security - Close account - Console error is displayed when closed account #14562

Closed
1 task
kbecciv opened this issue Jan 25, 2023 · 11 comments
Closed
1 task
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Jan 25, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Go to Setting - Security - Close account

Expected Result:

Console error is not displayed when closed account

Actual Result:

Console error is displayed when closed account

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Web/ Chrome

Version Number: 1.2.59.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Untitled

Bug5911510_Recording__249.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0127d6eba140b9c56a
  • Upwork Job ID: 1618769609192013824
  • Last Price Increase: 2023-01-27
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 25, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 25, 2023
@adelekennedy
Copy link

@alex-mechler dummy question, can something like this be worked on externally?

@alex-mechler
Copy link
Contributor

This should be able to be worked on externally, this is an error related to sending a message on the socket after it has already been closed generally.

@alex-mechler alex-mechler added the External Added to denote the issue can be worked on by a contributor label Jan 27, 2023
@melvin-bot melvin-bot bot unlocked this conversation Jan 27, 2023
@melvin-bot melvin-bot bot changed the title Web - Security - Close account - Console error is displayed when closed account [$1000] Web - Security - Close account - Console error is displayed when closed account Jan 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 27, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0127d6eba140b9c56a

@melvin-bot
Copy link

melvin-bot bot commented Jan 27, 2023

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jan 27, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 27, 2023

Current assignee @alex-mechler is eligible for the External assigner, not assigning anyone new.

@bernhardoj
Copy link
Contributor

I think this has the same root cause with this #14350

@alex-mechler
Copy link
Contributor

Ah good catch @bernhardoj! Going to remove the help wanted label from this for now to confirm that the fix for #14350 also fixes this issue!

@alex-mechler alex-mechler removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 30, 2023
@aimane-chnaif
Copy link
Contributor

#14526 is now merged into main and this issue is not reproducible anymore on dev.

@melvin-bot melvin-bot bot removed the Overdue label Jan 30, 2023
@Prince-Mendiratta
Copy link
Contributor

I can confirm that this issue is not related to closing the account flow, root cause was in the logout flow. With the PR merged, this issue will not be reproducible.

@alex-mechler
Copy link
Contributor

Confirmed that its no longer reproducible on dev. Since #14350 has the tracking for payment of @Prince-Mendiratta, and this was reported by Applause, closing this out! Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

6 participants