-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Web - Security - Close account - Console error is displayed when closed account #14562
Comments
@alex-mechler dummy question, can something like this be worked on externally? |
This should be able to be worked on externally, this is an error related to sending a message on the socket after it has already been closed generally. |
Job added to Upwork: https://www.upwork.com/jobs/~0127d6eba140b9c56a |
Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif ( |
Current assignee @alex-mechler is eligible for the External assigner, not assigning anyone new. |
I think this has the same root cause with this #14350 |
Ah good catch @bernhardoj! Going to remove the help wanted label from this for now to confirm that the fix for #14350 also fixes this issue! |
#14526 is now merged into |
I can confirm that this issue is not related to closing the account flow, root cause was in the logout flow. With the PR merged, this issue will not be reproducible. |
Confirmed that its no longer reproducible on dev. Since #14350 has the tracking for payment of @Prince-Mendiratta, and this was reported by Applause, closing this out! Thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Console error is not displayed when closed account
Actual Result:
Console error is displayed when closed account
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.2.59.1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5911510_Recording__249.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: