[SignOutFlow] proper pusher event type for user typing event #14526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>
melvin-bot
bot
requested review from
chiragsalian and
Santhosh-Sellavel
and removed request for
a team
|
@chiragsalian @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-01-27.at.1.10.56.AM.movMobile Web - SafariScreen.Recording.2023-01-27.at.1.19.21.AM.movMobile Web - ChromeScreen.Recording.2023-01-27.at.1.17.40.AM.movDesktopScreen.Recording.2023-01-27.at.1.12.58.AM.moviOSSimulator.Screen.Recording.-.iPhone.14.-.2023-01-27.at.01.35.27.mp4AndroidScreen.Recording.2023-01-27.at.1.23.45.AM.mov |
|
@chiragsalian @Prince-Mendiratta
|
|
@Santhosh-Sellavel Can you please share how you encountered this issue and the steps to reproduce this? |
|
I'm not sure what I did before but while performing logout this log showed, occurs randomly Screen.Recording.2023-01-27.at.1.48.08.AM.mov |
|
@Prince-Mendiratta |
|
@Santhosh-Sellavel I'll explore this and share my findings once I figure out the RCA. |
|
@Santhosh-Sellavel Looks like a regression caused by #12447. It was just merged a couple of minutes ago and you were able to encounter this. It's not caused due to Sign Out, but rather due to rendering of the RCAThe Solutiondiff --git a/src/components/LocalePicker.js b/src/components/LocalePicker.js
index ebd471ca96..8a347bc53a 100644
--- a/src/components/LocalePicker.js
+++ b/src/components/LocalePicker.js
@@ -47,6 +47,8 @@ const LocalePicker = (props) => {
return null;
}
return (
<Picker
label={props.size === 'normal' ? props.translate('preferencesPage.language') : null}
@@ -60,7 +62,7 @@ const LocalePicker = (props) => {
items={_.values(localesToLanguages)}
size={props.size}
value={props.preferredLocale}
- containerStyles={[props.size === 'small' && [styles.pickerContainerSmall]]}
+ containerStyles={props.size === 'small' ? [styles.pickerContainerSmall] : []}
/>
);
};How should we deal with reporting and fixing this? |
|
Thanks for the detailed analysis, I think the PR Author & Reviewer should take care of this one! |
Santhosh-Sellavel
approved these changes
Jan 26, 2023
|
@chiragsalian Left a comment for this warning here -> #12445 (comment) |
This was referenced Jan 26, 2023
6 tasks
54 tasks
|
@chiragsalian bump! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To DurationThere are no entries Meaningless Changes To DurationShow entries
Show details
|
Closed
1 task
13 tasks
|
🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.2.62-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.62-1 🚀
|
Prince-Mendiratta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prince Mendiratta prince.mendi@gmail.com
Details
Console error was popping up related to the websocket when the user logged out. The issue was related to the
pusher-jslibrary and the disconnection sequence for channels.Fixed Issues
$ #14350
#14350 (comment)
Tests
Offline tests
Although the network connectivity does not affect the behaviour, still adding the test to ensure all is good.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.Screenshots/Videos
Web
Web.2023-01-25.01-00-06.mp4
Safari Desktop
safari.mp4
Mobile Web - Chrome
mWeb-chrome.mp4
Mobile Web - Safari
mweb-safari.mp4
Desktop
desktop.mp4
iOS
ios.mp4
Android
android.mp4