[HOLD for payment 2023-02-07] Fix console errors with Locale Picker #14637

Luke9389 · 2023-01-27T20:26:49Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Context

This issue covers the fix for a bug pointed out here: #14526 (comment)
The RCA is accurate and the fix is effective.
The original PR that caused this is here: #12447 (comment)

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0105b02a675ed86a5e
Upwork Job ID: 1619082690033897472
Last Price Increase: 2023-01-27

Luke9389 · 2023-01-27T20:44:53Z

@maddylewis, please mark @Prince-Mendiratta as the reporting contributor here and make a reporting bonus Upwork job. Thank you! 🙇

maddylewis · 2023-01-27T21:04:19Z

can do! i'll leave a comment here once the contributor has been paid 👍

Luke9389 · 2023-01-27T21:11:03Z

@Prince-Mendiratta, we're going to move forward with paying you the reporting bonus because you provided an RCA and a solution. Please note that this won't always happen. Our guidelines have more details, but essentially, we want to pay you for the urgency and quality of your post here:

#14526 (comment)

Just know that in the future, this type of comment wouldn't actually qualify for payment.

melvin-bot · 2023-01-27T21:19:32Z

Job added to Upwork: https://www.upwork.com/jobs/~0105b02a675ed86a5e

melvin-bot · 2023-01-27T21:19:38Z

Current assignee @Santhosh-Sellavel is eligible for the Internal assigner, not assigning anyone new.

Prince-Mendiratta · 2023-01-27T21:20:33Z

Thank you @Luke9389! What should've I done instead after figuring out the RCA and solution?

Luke9389 · 2023-01-27T21:25:14Z

You would post those as a proposal on this issue.
But I decided not to make this an External issue because my PR broke it.

So I would say, don't start with an RCA until there's an External issue for the bug.

maddylewis · 2023-01-30T14:07:44Z

@Prince-Mendiratta - can you apply to this job so that i can process your payment? thanks!

https://www.upwork.com/jobs/~01e28bd15e44850c63

Prince-Mendiratta · 2023-01-30T15:20:59Z

@maddylewis It's probably an internal job, it says "access denied" to me and that I have to be invited to view the job

Can you please send me an invite? This is my profile at upwork.

parasharrajat · 2023-01-30T19:29:51Z

Not sure why I was not assigned as C+ to handle the RCA as per the process. This is a progressive change to the original PR #12447 (comment). That said, this issue does not qualify for C+ payment.

Luke9389 · 2023-01-30T20:01:57Z

Not sure why I was not assigned as C+ to handle the RCA as per the process.

My apologies @parasharrajat, this is my fault. @Santhosh-Sellavel was automatically added to the PR by melvin-bot, so I just assigned him here because he already had the context for the problem.

That said, this issue does not qualify for C+ payment.

Would you explain why this is the case, please?

parasharrajat · 2023-01-30T20:12:09Z

That said, this issue does not qualify for C+ payment.

IMO, and as per process because this comes under RCA and the original PR is still under regression period. Technically, I should have reviewed it as part of the original PR. But I leave that part to BugZero assignee and you.

Luke9389 · 2023-01-30T20:16:10Z

Ah OK. In the future, I'll follow that process. Since I made the mistake, I think we should pay @Santhosh-Sellavel for his review work on the PR. He tested on all platforms and verified the code.

Sorry about that. This will not happen again.

melvin-bot · 2023-01-31T19:27:14Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-01-31T19:27:15Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.62-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[No QA] LocalePicker Styles - fix small picker height #14638

If no regressions arise, payment will be issued on 2023-02-07. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-01-31T19:27:18Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Santhosh-Sellavel / @Luke9389] The PR that introduced the bug has been identified. Link to the PR:
[@Santhosh-Sellavel / @Luke9389] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Santhosh-Sellavel / @Luke9389] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@maddylewis] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

maddylewis · 2023-02-01T16:36:16Z

@Prince-Mendiratta - i've invited you to the job 👍

Prince-Mendiratta · 2023-02-01T16:40:26Z

@maddylewis Accepted, thank you!

maddylewis · 2023-02-06T18:56:15Z

@Prince-Mendiratta has been paid.

@Luke9389 - just making sure we're all set here before i close this one out. this issue was only created to get the reporting bonus processed, ya? lmk!

Luke9389 · 2023-02-06T18:57:22Z

Yep, we're good to close this out. Thanks!

Santhosh-Sellavel · 2023-02-06T19:20:11Z

Ah OK. In the future, I'll follow that process. Since I made the mistake, I think we should pay @Santhosh-Sellavel for his review work on the PR. He tested on all platforms and verified the code.

Sorry about that. This will not happen again.

bump @Luke9389 @maddylewis

maddylewis · 2023-02-06T20:22:58Z

@Santhosh-Sellavel - will you confirm the amount you're expecting for payment?

Santhosh-Sellavel · 2023-02-06T20:32:26Z

I'm not sure, we usually pay $1000 for internal PR reviews. If you feel the bounty should be reduced let me know the amount, thanks!

cc: @Luke9389 @maddylewis

maddylewis · 2023-02-06T20:58:07Z

okay gotcha. @Santhosh-Sellavel - will you link the issue that this comment is on? i just want to make sure im processing this one correctly. ty!

Santhosh-Sellavel · 2023-02-06T21:08:49Z

On this issue is only here -> #14637 (comment)

Luke9389 · 2023-02-06T21:16:44Z

I'm in agreement here. Sorry, I closed this out prematurely.

maddylewis · 2023-02-07T13:19:20Z

ok great! i'll get that payment processed shortly.

maddylewis · 2023-02-07T17:13:25Z

@Santhosh-Sellavel - will you share the name on your Upwork profile so that I can invite you to the job/process payment?

maddylewis · 2023-02-07T17:37:01Z

okay @Santhosh-Sellavel has been paid! sorry for the confusion!

Luke9389 added Daily KSv2 Weekly KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 27, 2023

Luke9389 self-assigned this Jan 27, 2023

melvin-bot bot locked and limited conversation to collaborators Jan 27, 2023

melvin-bot bot assigned maddylewis Jan 27, 2023

melvin-bot bot removed the Weekly KSv2 label Jan 27, 2023

Luke9389 mentioned this issue Jan 27, 2023

[No QA] LocalePicker Styles - fix small picker height #14638

Merged

54 tasks

melvin-bot bot added Reviewing Has a PR in review labels Jan 27, 2023

Prince-Mendiratta mentioned this issue Jan 27, 2023

[HOLD for payment 2023-02-03] [$1000] Update New Dot Text Inputs #12445

Closed

Luke9389 assigned Santhosh-Sellavel Jan 27, 2023

Luke9389 added the Internal Requires API changes or must be handled by Expensify staff label Jan 27, 2023

melvin-bot bot unlocked this conversation Jan 27, 2023

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jan 31, 2023

melvin-bot bot changed the title ~~Fix console errors with Locale Picker~~ [HOLD for payment 2023-02-07] Fix console errors with Locale Picker Jan 31, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Jan 31, 2023

maddylewis closed this as completed Feb 6, 2023

maddylewis reopened this Feb 6, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 6, 2023

maddylewis closed this as completed Feb 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-02-07] Fix console errors with Locale Picker #14637

[HOLD for payment 2023-02-07] Fix console errors with Locale Picker #14637

Luke9389 commented Jan 27, 2023 •

edited

Loading

Luke9389 commented Jan 27, 2023

maddylewis commented Jan 27, 2023 •

edited

Loading

Luke9389 commented Jan 27, 2023

melvin-bot bot commented Jan 27, 2023

melvin-bot bot commented Jan 27, 2023

Prince-Mendiratta commented Jan 27, 2023

Luke9389 commented Jan 27, 2023

maddylewis commented Jan 30, 2023

Prince-Mendiratta commented Jan 30, 2023 •

edited

Loading

parasharrajat commented Jan 30, 2023 •

edited

Loading

Luke9389 commented Jan 30, 2023

parasharrajat commented Jan 30, 2023 •

edited

Loading

Luke9389 commented Jan 30, 2023

melvin-bot bot commented Jan 31, 2023

melvin-bot bot commented Jan 31, 2023

melvin-bot bot commented Jan 31, 2023 •

edited by Luke9389

Loading

maddylewis commented Feb 1, 2023

Prince-Mendiratta commented Feb 1, 2023

maddylewis commented Feb 6, 2023

Luke9389 commented Feb 6, 2023

Santhosh-Sellavel commented Feb 6, 2023

maddylewis commented Feb 6, 2023

Santhosh-Sellavel commented Feb 6, 2023

maddylewis commented Feb 6, 2023

Santhosh-Sellavel commented Feb 6, 2023 •

edited

Loading

Luke9389 commented Feb 6, 2023

maddylewis commented Feb 7, 2023

maddylewis commented Feb 7, 2023

maddylewis commented Feb 7, 2023

[HOLD for payment 2023-02-07] Fix console errors with Locale Picker #14637

[HOLD for payment 2023-02-07] Fix console errors with Locale Picker #14637

Comments

Luke9389 commented Jan 27, 2023 • edited Loading

Context

Platforms:

Luke9389 commented Jan 27, 2023

maddylewis commented Jan 27, 2023 • edited Loading

Luke9389 commented Jan 27, 2023

melvin-bot bot commented Jan 27, 2023

melvin-bot bot commented Jan 27, 2023

Prince-Mendiratta commented Jan 27, 2023

Luke9389 commented Jan 27, 2023

maddylewis commented Jan 30, 2023

Prince-Mendiratta commented Jan 30, 2023 • edited Loading

parasharrajat commented Jan 30, 2023 • edited Loading

Luke9389 commented Jan 30, 2023

parasharrajat commented Jan 30, 2023 • edited Loading

Luke9389 commented Jan 30, 2023

melvin-bot bot commented Jan 31, 2023

melvin-bot bot commented Jan 31, 2023

melvin-bot bot commented Jan 31, 2023 • edited by Luke9389 Loading

maddylewis commented Feb 1, 2023

Prince-Mendiratta commented Feb 1, 2023

maddylewis commented Feb 6, 2023

Luke9389 commented Feb 6, 2023

Santhosh-Sellavel commented Feb 6, 2023

maddylewis commented Feb 6, 2023

Santhosh-Sellavel commented Feb 6, 2023

maddylewis commented Feb 6, 2023

Santhosh-Sellavel commented Feb 6, 2023 • edited Loading

Luke9389 commented Feb 6, 2023

maddylewis commented Feb 7, 2023

maddylewis commented Feb 7, 2023

maddylewis commented Feb 7, 2023

Luke9389 commented Jan 27, 2023 •

edited

Loading

maddylewis commented Jan 27, 2023 •

edited

Loading

Prince-Mendiratta commented Jan 30, 2023 •

edited

Loading

parasharrajat commented Jan 30, 2023 •

edited

Loading

parasharrajat commented Jan 30, 2023 •

edited

Loading

melvin-bot bot commented Jan 31, 2023 •

edited by Luke9389

Loading

Santhosh-Sellavel commented Feb 6, 2023 •

edited

Loading