Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2023-01-30 #14661

Closed
13 tasks done
OSBotify opened this issue Jan 30, 2023 · 12 comments
Closed
13 tasks done

Deploy Checklist: New Expensify 2023-01-30 #14661

OSBotify opened this issue Jan 30, 2023 · 12 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 30, 2023 •
edited by thienlnam
Loading

Release Version: 1.2.62-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.

cc @Expensify/applauseleads
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Jan 30, 2023
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 30, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.62-0 🚀

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.2.62-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.62-1 has been deployed to staging 🎉

@mvtglobally
Copy link

Regression is completed

PR #14526 is failing #14666

@thienlnam
Copy link
Contributor

cc @mvtglobally We recently CPed a PR to fix the #14666 deploy blocker - could you please retest?

@mvtglobally
Copy link

@thienlnam on it. Build 1.2.62-1?

@thienlnam
Copy link
Contributor

Yup!

@thienlnam
Copy link
Contributor

thienlnam commented Jan 31, 2023 •
edited
Loading

@mvtglobally Also #14665 deploy blocker as well please - We're having trouble reproducing but it might have been fixed in another PR

@mvtglobally
Copy link

#14666 seems resolved

Recording.3586.mp4

@mvtglobally
Copy link

#14665 is resolved as well on IOS AND Android

RPReplay_Final1675191484.MP4

@thienlnam
Copy link
Contributor

Perfect, thank you @mvtglobally !

@thienlnam thienlnam mentioned this issue Jan 31, 2023
Closed
6 tasks
@thienlnam
Copy link
Contributor

:shipit:

@Expensify Expensify unlocked this conversation Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thienlnam @applausebot @mvtglobally @OSBotify